Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7518)

Issue 1454002: Add x64 version of getcontext. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by anton
Modified:
9 years, 11 months ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Add x64 version of getcontext.

Assembly code is derived in part from code in libunwind.
Code tested on desktop linux (Android testing pending emulation
support).

BUG=346626

Patch Set 1 #

Total comments: 10

Patch Set 2 : x64 getcontext updates from review #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/android/breakpad_getcontext.S View 1 1 chunk +81 lines, -0 lines 0 comments Download
M common/android/breakpad_getcontext_unittest.cc View 1 2 chunks +79 lines, -0 lines 0 comments Download
M common/android/include/sys/ucontext.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
M common/android/include/sys/user.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
M common/android/ucontext_constants.h View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6
anton
9 years, 11 months ago #1
Lei Zhang (chromium)
Make sure using libunwind is ok. lgtm, with nits. https://breakpad.appspot.com/1454002/diff/1/common/android/breakpad_getcontext.S File common/android/breakpad_getcontext.S (right): https://breakpad.appspot.com/1454002/diff/1/common/android/breakpad_getcontext.S#newcode333 common/android/breakpad_getcontext.S:333: ...
9 years, 11 months ago #2
anton
https://breakpad.appspot.com/1454002/diff/1/common/android/breakpad_getcontext.S File common/android/breakpad_getcontext.S (right): https://breakpad.appspot.com/1454002/diff/1/common/android/breakpad_getcontext.S#newcode333 common/android/breakpad_getcontext.S:333: WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS ...
9 years, 11 months ago #3
dannyb
lgtm
9 years, 11 months ago #4
rmcilroy
On 2014/04/11 15:14:14, dannyb wrote: > lgtm I will land this for anton.
9 years, 11 months ago #5
anton
9 years, 11 months ago #6
On 2014/04/11 16:12:29, rmcilroy wrote:
> On 2014/04/11 15:14:14, dannyb wrote:
> > lgtm
> 
> I will land this for anton.

Thanks Ross for landing. Will close issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted