Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 1214002: minidump-2-core: Allow user to override shared lib basedir.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by kouhei
Modified:
7 years, 3 months ago
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

minidump-2-core: Allow user to override shared lib basedir.

This CL introduces "--sobasedir" command-line option to minidump-2-core.
By default, paths to shared lib files included in generated core file are
formatted as "/var/lib/breakpad/[GUID]libFoobar.so". By using "--sobasedir",
this will be "[user-supplied-path]libFoobar.so".

This option can be used to ease debugging minidump files from developer's local
builds. By specifying "minidump-2-core --sobasedir `pwd`/out/Debug/lib/
foobar.mdmp", user can load the generated core file in gdb without setting up
the symlinks for "/var/lib/breakpad".

BUG=None

Patch Set 1 #

Total comments: 1

Patch Set 2 : renamed #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M tools/linux/md2core/minidump-2-core.cc View 1 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3
kouhei
Would you take a look? I'm using this to debug minidump files generated from Chrome's ...
7 years, 4 months ago #1
Lei Zhang (chromium)
late lgtm I usually just manually do some post processing within gdb, but this might ...
7 years, 3 months ago #2
kouhei
7 years, 3 months ago #3
Thanks for your review!

Renamed the var. Would you commit this patch? I can't commit this by myself as
I'm not a breakpad committer.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted