Add -[BreakpadController resetConfiguration] for iOS.

Add -[BreakpadController resetConfiguration] for iOS.

Add a resetConfiguration method to BreakpadController for iOS. The new method
resets the controller configuration to its initial value, which is the
infoDictionary of the bundle of the application.

BUG=554

[blundell]

LGTM

[kiyun]

On 2013/12/11 16:39:36, blundell wrote:
> LGTM

Thank you.

Can you please land it for me?

[blundell]

Had some more thoughts on this CL.

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm
File client/ios/BreakpadController.mm (right):

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm#n...
client/ios/BreakpadController.mm:183: [configuration_
addEntriesFromDictionary:configuration];
I didn't find any documentation about the behavior of this method when nil is
passed in.

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm#n...
client/ios/BreakpadController.mm:195: [self updateConfiguration:nil];
If your goal is to have the state of the configuration be exactly as it is at
the end of initSingleton, I think you should be executing the code at lines
114-116 rather than the code at lines 184-187. What do you think of moving the
code from lines 114-116 into this method and having initSingleton call
resetConfiguration?

[kiyun]

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm
File client/ios/BreakpadController.mm (right):

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm#n...
client/ios/BreakpadController.mm:195: [self updateConfiguration:nil];
On 2013/12/12 14:27:22, blundell wrote:
> If your goal is to have the state of the configuration be exactly as it is at
> the end of initSingleton, I think you should be executing the code at lines
> 114-116 rather than the code at lines 184-187. What do you think of moving the
> code from lines 114-116 into this method and having initSingleton call
> resetConfiguration?

I see. The difference is when the bundle sets the report interval to 0, right?
Also structurally this will ensure that any other initialization logic happens
here too. Your suggestion makes sense to me.

[blundell]

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm
File client/ios/BreakpadController.mm (right):

https://breakpad.appspot.com/904002/diff/1/client/ios/BreakpadController.mm#n...
client/ios/BreakpadController.mm:195: [self updateConfiguration:nil];
Yep. Note that a value of 0 prevents uploads, so after the client calls this
method it will have to call -setUploadInterval in that case if it wants uploads
to occur (exactly as it would have had to when initializing Breakpad).

On 2013/12/12 14:33:40, kiyun wrote:
> On 2013/12/12 14:27:22, blundell wrote:
> > If your goal is to have the state of the configuration be exactly as it is
at
> > the end of initSingleton, I think you should be executing the code at lines
> > 114-116 rather than the code at lines 184-187. What do you think of moving
the
> > code from lines 114-116 into this method and having initSingleton call
> > resetConfiguration?
> 
> I see. The difference is when the bundle sets the report interval to 0, right?
> Also structurally this will ensure that any other initialization logic happens
> here too. Your suggestion makes sense to me.

[kiyun]

PTAL

Thanks for the suggestion!

[blundell]

LGTM (again)

[kiyun]

On 2013/12/12 14:48:08, blundell wrote:
> LGTM (again)

Thanks. Can you land it for me?

[blundell]

Committed as r1256