Add -[BreakpadController resetConfiguration] for iOS.

client/ios/BreakpadController.mm

 // Copyright (c) 2012, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 162 matching lines @@
         [NSObject cancelPreviousPerformRequestsWithTarget:self
             selector:@selector(sendStoredCrashReports)
             object:nil];
       }
   });
 }
 
 - (void)updateConfiguration:(NSDictionary*)configuration {
   NSAssert(!started_,
       @"The controller must not be started when updateConfiguration is called");
   [configuration_ addEntriesFromDictionary:configuration];

[blundell, 2013/12/12 14:27:22]

I didn't find any documentation about the behavior of this method when nil is
passed in.

   NSString* uploadInterval =
       [configuration_ valueForKey:@BREAKPAD_REPORT_INTERVAL];
   if (uploadInterval)
     [self setUploadInterval:[uploadInterval intValue]];
 }
 
+- (void)resetConfiguration {
+  NSAssert(!started_,
+      @"The controller must not be started when resetConfiguration is called");
+  [configuration_ autorelease];
+  configuration_ = [[[NSBundle mainBundle] infoDictionary] mutableCopy];
+  [self updateConfiguration:nil];

[blundell, 2013/12/12 14:27:22]

If your goal is to have the state of the configuration be exactly as it is at
the end of initSingleton, I think you should be executing the code at lines
114-116 rather than the code at lines 184-187. What do you think of moving the
code from lines 114-116 into this method and having initSingleton call
resetConfiguration?

[kiyun, 2013/12/12 14:33:40]

I see. The difference is when the bundle sets the report interval to 0, right?
Also structurally this will ensure that any other initialization logic happens
here too. Your suggestion makes sense to me.

[blundell, 2013/12/12 14:37:32]

Yep. Note that a value of 0 prevents uploads, so after the client calls this
method it will have to call -setUploadInterval in that case if it wants uploads
to occur (exactly as it would have had to when initializing Breakpad).

On 2013/12/12 14:33:40, kiyun wrote:

+}
+
 - (void)setUploadingURL:(NSString*)url {
   NSAssert(!started_,
       @"The controller must not be started when setUploadingURL is called");
   [configuration_ setValue:url forKey:@BREAKPAD_URL];
 }
 
 - (void)setUploadInterval:(int)intervalInSeconds {
   NSAssert(!started_,
       @"The controller must not be started when setUploadInterval is called");
   [configuration_ removeObjectForKey:@BREAKPAD_REPORT_INTERVAL];
@@ skipping 93 matching lines @@
 
       // A report must be sent later.
       if (timeToWait > 0)
         [self performSelector:@selector(sendStoredCrashReports)
                    withObject:nil
                    afterDelay:timeToWait];
   });
 }
 
 @end