Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 1484002: Increase Breakpad's signal handler stack size. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rmcilroy
Modified:
10 years ago
Reviewers:
Mark Mentovai
CC:
primiano
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Increase Breakpad's signal handler stack size.

Some unittests fail on Android (both on Arm and Arm64) without this stack
size increase.

BUG=354405,335641
R=mark@chromium.org

Committed: 1307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/handler/exception_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rmcilroy
With this CL, the Arm64 build of breakpad_unittests passes almost all the tests, and the ...
10 years ago #1
Mark Mentovai
LGTM
10 years ago #2
rmcilroy
10 years ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1307 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted