Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 639002: Support symbol dumping for ARMV8 iOS apps. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by blundell
Modified:
10 years, 6 months ago
Reviewers:
Mark Mentovai, qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Support symbol dumping for ARMV8 iOS apps.

In my testing, ARM V8 object files and ARM V8 slices of universal binaries do
not contain debug_frame sections (at least at this time), and hence dump_syms
does not output CFI for ARM V8 even in the absence of the "-c" flag.

Patch by:blundell@chromium.org

BUG=542

Patch Set 1 #

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/mac/arch_utilities.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M common/mac/macho_reader.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
blundell
Hi, I don't see any obvious place for adding unit tests but would be happy ...
10 years, 6 months ago #1
qsr
As discussed offline, please review the name of the architecture and the defines using the ...
10 years, 6 months ago #2
blundell
On 2013/10/15 08:23:56, qsr wrote: > As discussed offline, please review the name of the ...
10 years, 6 months ago #3
qsr
10 years, 6 months ago #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted