Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(496)

Issue 642002: Support symbol dumping for ARMV8 iOS apps. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by blundell
Modified:
10 years, 6 months ago
Reviewers:
Mark Mentovai, qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Support symbol dumping for ARMV8 iOS apps.

In my testing, ARM V8 object files and ARM V8 slices of universal binaries do
not contain debug_frame sections (at least at this time), and hence dump_syms
does not output CFI for ARM V8 even in the absence of the "-c" flag.

Patch by:blundell@chromium.org

BUG=542

Patch Set 1 #

Patch Set 2 : Rename CPU type and subtype to match system names #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/mac/arch_utilities.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M src/common/mac/macho_reader.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
blundell
This patch is taking over from https://breakpad.appspot.com/639002/; as Ben observed, I was previously working from ...
10 years, 6 months ago #1
qsr
LGTM
10 years, 6 months ago #2
blundell
10 years, 6 months ago #3
Message was sent while issue was closed.
Committed by qsr@chromium.org as r1222.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted