Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 1304002: Make ARM64 detection consistent in chromium.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by primiano
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai, blundell
CC:
rmcilroy, bulach_chromium.org
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

Make ARM64 detection consistent in chromium.

This is to uniform ARM64 detection code in chromium.
Use only __aarch64__ and don't look for __arm64__ at all.


BUG=chromium:354405, chromium:358092

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/mac/handler/dynamic_images.h View 1 chunk +1 line, -1 line 0 comments Download
M client/mac/handler/exception_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M client/mac/handler/minidump_generator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M client/mac/handler/ucontext_compat.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
primiano
Mark could you please take a look. I am trying to make the __arm64__ vs ...
7 years, 4 months ago #1
Mark Mentovai
arm64 is more of a “says what it means” than aarch64 for most people. Why ...
7 years, 3 months ago #2
primiano
On 2014/04/01 14:09:42, Mark Mentovai wrote: > arm64 is more of a “says what it ...
7 years, 3 months ago #3
Mark Mentovai
LGTM. I agree that consistency wins, I just wanted to know why you chose the ...
7 years, 3 months ago #4
primiano
On 2014/04/01 14:33:01, Mark Mentovai wrote: > LGTM. I agree that consistency wins, I just ...
7 years, 3 months ago #5
primiano
BTW, how am I supposed to land this? Can you do that for me? Or ...
7 years, 3 months ago #6
Mark Mentovai
7 years, 3 months ago #7
+blundell too as an FYI, since he added ARM64 iOS support.

Committed Breakpad r1293. Let me know if you plan on making more changes to
Breakpad, and I’ll give you write access.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted