Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(955)

Issue 1624003: Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by rmcilroy
Modified:
9 years, 11 months ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is
dumped.

On certain versions of Android (specifically JellyBean MR2 on Nexus 7, possibly
others too) no ELF core dump is created for crashing processes.  Check for this
and skip the test if so.

BUG=364943
R=thestig@chromium.org

Committed: 1318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/linux/minidump_writer/linux_core_dumper_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M common/linux/elf_core_dump_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rmcilroy
thestig@: please take a look. See the attached bug for details of why this is ...
9 years, 11 months ago #1
Lei Zhang (chromium)
lgtm, though I hope you work out the problem and remove this later.
9 years, 11 months ago #2
rmcilroy
9 years, 11 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1318 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted