Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

‹ Newer 21 - 40 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
2844002	Follow debug link correctly (Closed)	hashimoto	Ted Mielczarek, vapier, Lei Zhang (chromium), Ben Chan, Mark Mentovai	4	10 years, 4 months
2854002	Demangle symbol name (Closed)	hashimoto	Mark Mentovai	4	10 years, 4 months
4724002	Handle failures of copying process data from a core file. (Closed)	Ben Chan	Mark Mentovai, vapier, Lei Zhang (chromium)	9	10 years, 4 months
1204002	Trim unintentional whitespace and fix style nits (Closed)	mdempsky	Lei Zhang (chromium), vapier		10 years, 4 months
6684002	Remove unneeded definitions of O_BINARY (Closed)	j.turney	Ted Mielczarek, vapier		10 years, 5 months
3754002	Remove unused variable 'kGUIDStringSize' in microdump_writer_unittest. (Closed)	Ben Chan	Mark Mentovai, vapier		10 years, 5 months
6724002	Fix copyright notice in dump_context.cc (Closed)	primiano	vapier		10 years, 5 months
8694002	Stop calling memmove when unnecessary (Closed)	hashimoto	Mark Mentovai		10 years, 5 months
10704002	Fix some fragile code that is likely to cause future memory corruption problems. (Closed)	erikchen	Mark Mentovai	10	10 years, 5 months
8694003	Fix a source of memory corruption. (Closed)	erikchen	Mark Mentovai	2	10 years, 5 months
9744002	Modify minidump_stackwalk to be more tolerant of overlapping ranges. (Closed)	Will Harris	Lei Zhang (chromium), Mark Mentovai	6	10 years, 6 months
472002	minidump_stackwalk: implement -a <address> option (Closed)	jaysoffian	Mark Mentovai, Ted Mielczarek		10 years, 6 months
1764002	Remove pointers from serialized file format (Closed)	mdempsky	Lei Zhang (chromium)		10 years, 6 months
5764002	Remove pointers from serialized file format (Closed)	mdempsky			10 years, 6 months
5744002	dump_syms: Fix handling of DW_FORM_ref_addr to work with DWARF 4 (Closed)	mseaborn	Roland McGrath, Mark Mentovai	5	10 years, 6 months
2824002	Microdumps: support aarch64 and lib mapping from APK (Closed)	primiano	mmandlis	3	10 years, 6 months
7754002	Surfacing the process create time in google_breakpad::ProcessState (Closed)	ivanpe	Mark Mentovai, Ted Mielczarek, mmandlis	2	10 years, 7 months
4704002	Introduce microdump_stackwalk comand line executable (Closed)	primiano	mmandlis, Mark Mentovai	6	10 years, 7 months
2814002	Fix microdump_writer and add unittest. (Closed)	primiano	mmandlis	2	10 years, 7 months
5714003	Microdump processing implementation (Closed)	mmandlis	primiano, subportt	102	10 years, 7 months

‹ Newer 21 - 40 Older ›