Issue 8694003: Fix a source of memory corruption.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 8694003: Fix a source of memory corruption. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 3 months ago by erikchen

Modified:
9 years, 3 months ago

Reviewers:
Mark Mentovai

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix a source of memory corruption.

This error was causing crashes in official Chrome Mac builds on 10.8.5 
machines.

BUG=chromium:449214
R=mark@chromium.org

Patch Set 3 : Comments from mark. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/dwarf_cu_to_module.cc	View	1 2	2 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM. Good catch. https://breakpad.appspot.com/8694003/diff/20001/common/dwarf_cu_to_module.cc File common/dwarf_cu_to_module.cc (right): https://breakpad.appspot.com/8694003/diff/20001/common/dwarf_cu_to_module.cc#newcode399 common/dwarf_cu_to_module.cc:399: // Prepare the return value before ...

9 years, 3 months ago #2

erikchen

https://breakpad.appspot.com/8694003/diff/20001/common/dwarf_cu_to_module.cc File common/dwarf_cu_to_module.cc (right): https://breakpad.appspot.com/8694003/diff/20001/common/dwarf_cu_to_module.cc#newcode399 common/dwarf_cu_to_module.cc:399: // Prepare the return value before upcoming mutations to ...

9 years, 3 months ago #3

erikchen

9 years, 3 months ago #5

Message was sent while issue was closed.

Manually submitted patch set 3 as
https://code.google.com/p/google-breakpad/source/detail?r=1414

Expand All Messages | Collapse All Messages