Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1010)

Issue 2854002: Demangle symbol name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by hashimoto
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Demangle symbol name

The spec says it should be demangled.
https://code.google.com/p/google-breakpad/wiki/SymbolFiles

BUG=chromium:453498
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1421

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/dwarf_cu_to_module.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/common/linux/elf_symbols_to_module.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hashimoto
Could you review this?
9 years, 2 months ago #1
Mark Mentovai
https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_module.cc File src/common/linux/elf_symbols_to_module.cc (right): https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_module.cc#newcode159 src/common/linux/elf_symbols_to_module.cc:159: std::string name = SymbolString(iterator->name_offset, strings); Why introduce name as ...
9 years, 2 months ago #2
hashimoto
https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_module.cc File src/common/linux/elf_symbols_to_module.cc (right): https://breakpad.appspot.com/2854002/diff/1/src/common/linux/elf_symbols_to_module.cc#newcode159 src/common/linux/elf_symbols_to_module.cc:159: std::string name = SymbolString(iterator->name_offset, strings); On 2015/01/30 13:22:21, Mark ...
9 years, 1 month ago #3
Mark Mentovai
LGTM
9 years, 1 month ago #4
hashimoto
9 years, 1 month ago #5
Message was sent while issue was closed.
Committed patchset #2 (id:50001) manually as r1421 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted