Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3439)

Issue 1764002: Remove pointers from serialized file format (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by mdempsky
Modified:
9 years, 3 months ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove pointers from serialized file format

BUG=breakpad:621
R=thestig@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1410

Patch Set 1 #

Patch Set 2 : Use ElfW(Addr) instead of void* to be consistent #

Patch Set 3 : Add minidump_type_helper.h #

Patch Set 4 : Remove unnecessary 'typename' keyword #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer.cc View 1 2 5 chunks +9 lines, -5 lines 0 comments Download
A src/common/minidump_type_helper.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_format.h View 2 chunks +28 lines, -10 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 1 2 3 5 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 4
mdempsky
9 years, 3 months ago #1
Lei Zhang (chromium)
lgtm
9 years, 3 months ago #2
mdempsky
On 2014/12/08 21:33:19, Lei Zhang (chromium) wrote: > lgtm Thanks for the quick review. How ...
9 years, 3 months ago #3
mdempsky
9 years, 3 months ago #4
Message was sent while issue was closed.
Committed patchset #4 (id:100001) manually as r1410 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted