Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 261 - 280 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
674003	NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args) (Closed)	Mark Mentovai	mochalatte, thakis	2	12 years, 9 months
654002	Add SIGTRAP to the handled signals on Linux (Closed)	jochen	Mark Mentovai		12 years, 9 months
684002	Warning on unused const variable. (Closed)	yunlian1	vapier, Ben Chan		12 years, 9 months
631003	Print HTTP response code in linux/sym_upload on failure	mattdr	google-breakpad-dev, Ivan Penkov		12 years, 9 months
674002	Use scoped_array instead of inappropriate scoped_ptr (Closed)	Jess	Ivan Penkov, ivanpe.google, Lei Zhang (chromium)		12 years, 9 months
636002	increase exception handler stack size for dumping thread (Closed)	vapier	Ted Mielczarek, Ben Chan		12 years, 9 months
643002	Remove define of mach_vm_region from mach_vm_compatibility.h. (Closed)	blundell	qsr		12 years, 9 months
642002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		12 years, 9 months
639002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		12 years, 9 months
640002	Remove unittest from sources list of iOS client xcodeproj. (Closed)	blundell	qsr		12 years, 9 months
596002	Always read CFI section, even when not outputing CFI information. (Closed)	qsr	Mark Mentovai, Ted Mielczarek, blundell	1	12 years, 9 months
637004	Fix missing include in ios_exception_minidump_generator.mm (Closed)	blundell	qsr		12 years, 10 months
634002	Fix for failing mips stackwalker unittest. (Closed)	gordanac	digit, Mark Mentovai, Ivan Penkov		12 years, 10 months
635002	In NonAllocatingMap, remove asserts around key/value length. (Closed)	rsesek	Mark Mentovai		12 years, 10 months
632003	Stricter validation checks for symbol parser functions. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess	10	12 years, 10 months
633002	Fix the Android/MIPS build. (Closed)	digit	Mark Mentovai, thakis, Ivan Penkov, Petar Jovanovic, gordana.cmiljanovic, Petar.Jovanovic		12 years, 10 months
632002	Adding mips support for Android. (Closed)	gordanac	Mark Mentovai, Ivan Penkov, digit	1	12 years, 10 months
586002	Try getting file-ids from memory when possible, and fallback to reading files otherwise	glandium	Ted Mielczarek, vapier	9	12 years, 10 months
629002	Handle block helper functions in Breakpad symbol parser. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess		12 years, 10 months
622002	Add rudimentary Linux exploitability analysis	mattdr	Cris Neckar	1	12 years, 10 months

« Newest ‹ Newer 261 - 280 Older ›