Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 586002: Try getting file-ids from memory when possible, and fallback to reading files otherwise

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by glandium
Modified:
7 years, 10 months ago
Reviewers:
Ted Mielczarek, vapier
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Try getting file-ids from memory when possible, and fallback to reading files
otherwise

Patch Set 1 #

Total comments: 8

Patch Set 2 : Modified the LinuxDumper::ElfFileIdentifierForMapping comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_dumper.cc View 1 1 chunk +18 lines, -11 lines 1 comment Download

Messages

Total messages: 9
glandium
8 years, 2 months ago #1
Ted Mielczarek
Just one comment, otherwise LGTM. https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode106 src/client/linux/minidump_writer/linux_dumper.cc:106: size_t size = getpagesize(); ...
8 years, 1 month ago #2
vapier
https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode103 src/client/linux/minidump_writer/linux_dumper.cc:103: // Try getting the file-id from the first page ...
8 years, 1 month ago #3
glandium
https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode103 src/client/linux/minidump_writer/linux_dumper.cc:103: // Try getting the file-id from the first page ...
8 years, 1 month ago #4
Ted Mielczarek
https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode106 src/client/linux/minidump_writer/linux_dumper.cc:106: size_t size = getpagesize(); The comments about avoiding glibc ...
8 years, 1 month ago #5
vapier
https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode103 src/client/linux/minidump_writer/linux_dumper.cc:103: // Try getting the file-id from the first page ...
8 years, 1 month ago #6
glandium
https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (right): https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode106 src/client/linux/minidump_writer/linux_dumper.cc:106: size_t size = getpagesize(); On 2013/06/06 19:55:27, Ted Mielczarek ...
8 years ago #7
vapier
https://breakpad.appspot.com/586002/diff/8001/src/client/linux/minidump_writer/linux_dumper.cc File src/client/linux/minidump_writer/linux_dumper.cc (left): https://breakpad.appspot.com/586002/diff/8001/src/client/linux/minidump_writer/linux_dumper.cc#oldcode106 src/client/linux/minidump_writer/linux_dumper.cc:106: if (mapping.start_addr == auxv_[AT_SYSINFO_EHDR]) { what tree is this ...
7 years, 10 months ago #8
glandium
7 years, 10 months ago #9
On 2013/09/25 07:06:51, vapier wrote:
>
https://breakpad.appspot.com/586002/diff/8001/src/client/linux/minidump_write...
> File src/client/linux/minidump_writer/linux_dumper.cc (left):
> 
>
https://breakpad.appspot.com/586002/diff/8001/src/client/linux/minidump_write...
> src/client/linux/minidump_writer/linux_dumper.cc:106: if (mapping.start_addr
==
> auxv_[AT_SYSINFO_EHDR]) {
> what tree is this patch made against ?  i don't see this logic ever being
> written this way in trunk/.

There are several patches that this one depends upon. See
https://bugzilla.mozilla.org/show_bug.cgi?id=689178#c7 for the ordered list of
issues.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted