Issue 632002: Adding mips support for Android.

Issue 632002: Adding mips support for Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by gordanac

Modified:
10 years, 7 months ago

Reviewers:
Mark Mentovai, Ivan Penkov, digit

CC:
Petar Jovanovic, petar.jovanovic_imgtec.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adding mips support for Android.

Mips linux support has been added previously in r1212. Some additional changes
are required to make breakpad functional on Android.

BUG=none
TEST=build, unittests, chrome test application

Commited: https://code.google.com/p/google-breakpad/source/detail?r=1215

Patch Set 2 : Modified breakpad_getcontext. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/handler/exception_handler_unittest.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/common/android/breakpad_getcontext.S	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
M	src/common/android/breakpad_getcontext_unittest.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/common/android/include/sys/ucontext.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/common/android/include/sys/user.h	View		1 chunk	+17 lines, -2 lines	0 comments	Download
M	src/common/android/ucontext_constants.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/common/linux/dump_symbols.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/common/minidump_cpu_mips.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ivan Penkov

https://breakpad.appspot.com/632002/diff/1/src/common/android/breakpad_getcontext.S File src/common/android/breakpad_getcontext.S (right): https://breakpad.appspot.com/632002/diff/1/src/common/android/breakpad_getcontext.S#newcode145 src/common/android/breakpad_getcontext.S:145: // https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/mips/getcontext.S;h=1e77467cb218c623cea702ad29abb40eb5477c70;hb=ff3475331e3007db16d792b1e1489170b71308a1 The original implementation is released under the ...

10 years, 7 months ago #2

Message was sent while issue was closed.

Sorry, I was ooo lately. First of all, thanks for this patch, it's really nice.
I've just updated my local copy to revision 1215.

Unfortunately, this breaks the Android build when using the latest official NDK
(r9). I suppose you've been building this with a custom NDK or updated platform
sources instead. I will upload a new patch that fixes this very soon.

On the other hand, when running "make check" after a clean build on my machine,
a new test is consistently failing (on Linux/x86_64, and Android builds as
well), see below. I don't know enough about MIPS-related CFI blocks to determine
what's wrong, but can I ask you to have a look at it?

Thanks.

-------------------------- cut here -------------------------------

[----------] 3 tests from CFI
[ RUN      ] CFI.At4004
2013-09-25 13:28:19: source_line_resolver_base.cc:236: INFO: Loading symbols for
module module1 from memory buffer
/opt/digit/upstream/google-breakpad/src/processor/stackwalker_mips_unittest.cc:628:
Failure
Value of: frame1->context.epc
  Actual: 4216064
Expected: expected.epc
Which is: 4216072
/opt/digit/upstream/google-breakpad/src/processor/stackwalker_mips_unittest.cc:629:
Failure
Value of: frame1->instruction
  Actual: 4216064
Expected: expected.epc
Which is: 4216072
[  FAILED  ] CFI.At4004 (0 ms)

Expand All Messages | Collapse All Messages