Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 631003: Print HTTP response code in linux/sym_upload on failure

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by mattdr
Modified:
7 years, 9 months ago
Reviewers:
google-breakpad-dev, Ivan Penkov
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

HTTPUpload::SendRequest returns false for "failed" requests, which includes
non-2xx responses. Print the response code in those cases to help with
debugging.

Recreating a previous issue deleted due to my own incompetence. Sorry for the
noise.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
src/tools/linux/symupload/sym_upload.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
mattdr
7 years, 10 months ago #1
Ivan Penkov
7 years, 9 months ago #2
On 2013/09/16 20:52:04, mattdr wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted