Always read CFI section, even when not outputing CFI information.

Always read CFI section, even when not outputing CFI information.

 On iOS at least, the CFI section contains information needed to
correctly dump the symbols. Even if the CFI section is not dumped,
reading it is necessary to get correcty symbolication.

R=mark@chromium.org, ted.mielczarek@gmail.com

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1182

[qsr]

Mark for review, as this is needed for Chrome on iOS current beta.

 +Ted as this is reverting part of https://breakpad.appspot.com/517002

[Ted Mielczarek]

LGTM, I'm not relying on this behavior, it just seemed like the right thing to
do. (We're using the inverse, just loading CFI.)

[Mark Mentovai]

LGTM

[qsr]

Committed patchset #1 manually as r1182 (presubmit successful).

[blundell]

https://breakpad.appspot.com/596002/diff/1/src/common/mac/dump_syms.mm
File src/common/mac/dump_syms.mm (left):

https://breakpad.appspot.com/596002/diff/1/src/common/mac/dump_syms.mm#oldcod...
src/common/mac/dump_syms.mm:408: module_->SetLoadAddress(segment.vmaddr);
The cause of the incorrect behavior that Ben was experiencing is that this line
should not have been put under the additional condition |symbol_data_ != NO_CFI|
as part of https://breakpad.appspot.com/517002/.