Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 517002: Allow dumping just CFI data from debug symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by Ted Mielczarek
Modified:
7 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The inverse of what the existing code allows (skipping CFI), we'd like to be
able to skip everything *but* CFI. We're using this code for in-process
unwinding, and we don't need function or line info, so skipping it saves us
time. I've changed the 'bool cfi' parameter into an enum for more flexibility so
you can specify ALL_SYMBOL_DATA, NO_CFI or ONLY_CFI.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Updated patch #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/dump_symbols.cc View 1 6 chunks +82 lines, -75 lines 0 comments Download
M src/common/linux/dump_symbols.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/common/linux/dump_symbols_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/common/mac/dump_syms.h View 1 3 chunks +10 lines, -5 lines 0 comments Download
M src/common/mac/dump_syms.mm View 1 4 chunks +23 lines, -13 lines 0 comments Download
M src/common/module.cc View 1 chunk +47 lines, -45 lines 0 comments Download
M src/common/module.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/common/module_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
A src/common/symbol_data.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
M src/tools/linux/dump_syms/dump_syms.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/tools/mac/dump_syms/dump_syms_tool.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Ted Mielczarek
7 years, 6 months ago #1
Lei Zhang (chromium)
Looks good overall. Basically all nits: http://breakpad.appspot.com/517002/diff/1/src/common/linux/dump_symbols.cc File src/common/linux/dump_symbols.cc (right): http://breakpad.appspot.com/517002/diff/1/src/common/linux/dump_symbols.cc#newcode548 src/common/linux/dump_symbols.cc:548: fprintf(stderr, "%s: \".stab\" ...
7 years, 6 months ago #2
Ted Mielczarek
7 years, 6 months ago #3
Lei Zhang (chromium)
7 years, 6 months ago #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted