Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(683)

Unified Diff: src/tools/mac/dump_syms/dump_syms_tool.mm

Issue 517002: Allow dumping just CFI data from debug symbols (Closed)
Patch Set: Updated patch Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/tools/linux/dump_syms/dump_syms.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/tools/mac/dump_syms/dump_syms_tool.mm
===================================================================
--- a/src/tools/mac/dump_syms/dump_syms_tool.mm
+++ b/src/tools/mac/dump_syms/dump_syms_tool.mm
@@ -49,17 +49,17 @@ struct Options {
Options() : srcPath(), arch(), cfi(true) { }
NSString *srcPath;
const NXArchInfo *arch;
bool cfi;
};
//=============================================================================
static bool Start(const Options &options) {
- DumpSymbols dump_symbols;
+ DumpSymbols dump_symbols(options.cfi ? ALL_SYMBOL_DATA : NO_CFI);
if (!dump_symbols.Read(options.srcPath))
return false;
if (options.arch) {
if (!dump_symbols.SetArchitecture(options.arch->cputype,
options.arch->cpusubtype)) {
fprintf(stderr, "%s: no architecture '%s' is present in file.\n",
@@ -81,17 +81,17 @@ static bool Start(const Options &options
else
fprintf(stderr, "unrecognized cpu type 0x%x, subtype 0x%x\n",
arch->cputype, arch->cpusubtype);
}
return false;
}
}
- return dump_symbols.WriteSymbolFile(std::cout, options.cfi);
+ return dump_symbols.WriteSymbolFile(std::cout);
}
//=============================================================================
static void Usage(int argc, const char *argv[]) {
fprintf(stderr, "Output a Breakpad symbol file from a Mach-o file.\n");
fprintf(stderr, "Usage: %s [-a ARCHITECTURE] [-c] <Mach-o file>\n",
argv[0]);
fprintf(stderr, "\t-a: Architecture type [default: native, or whatever is\n");
« no previous file with comments | « src/tools/linux/dump_syms/dump_syms.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted