Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 221 - 240 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
944003	Use a proper ignore_result() to fix a ftruncate warn_unused_result warning with GCC 4.8. (Closed)	Lei Zhang (chromium)	Mark Mentovai	2	12 years, 3 months
964002	Switch scoped_ptr.h to a compatible google3 implementation. (Closed)	Lei Zhang (chromium)	Mark Mentovai	2	12 years, 3 months
455002	Add MMX detection when getting registers in Linux	aras.vaichas	Ted Mielczarek, Lei Zhang (chromium)	3	12 years, 3 months
944002	Fix warnings from the Windows build. (Closed)	Lei Zhang (chromium)	Mark Mentovai	3	12 years, 3 months
934002	Run svn propdel svn:executable on source code files. (Closed)	Lei Zhang (chromium)			12 years, 3 months
904004	Fix error from r1258. (Closed)	Lei Zhang (chromium)	Cris Neckar, Mark Mentovai		12 years, 3 months
894002	Expose the ability to supply additional user streams in the windows dump generator. (Closed)	Cris Neckar	Mark Mentovai, Ted Mielczarek, cyberparser, Lei Zhang (chromium)	1	12 years, 3 months
914002	Making the Mac build of crash_report work again after the last SVN sync. This includes correction o… (Closed)	Ivan Penkov	tschweitzer, Mark Mentovai, Lei Zhang (chromium), nealsid		12 years, 3 months
924002	Fix gcc vs clang cpuid.h discrepency. (Closed)	Lei Zhang (chromium)	Mark Mentovai, thakis	2	12 years, 3 months
904003	Misc Android-related fixes. (Closed)	digit	Mark Mentovai, Ted Mielczarek	6	12 years, 3 months
854002	Remove usage of gDebugLog by directly using the VERBOSE preprocessor define (Closed)	altse	Mark Mentovai		12 years, 3 months
824002	Avoid redefinition of global static debug flag and remove unneeded GTMDefines.h" (Closed)	altse	Mark Mentovai, mostynb, altse		12 years, 3 months
834002	Include guards and avoid redefinition of false/true in convert_UTF. (Closed)	altse	Mark Mentovai		12 years, 3 months
904002	Add -[BreakpadController resetConfiguration] for iOS. (Closed)	kiyun	blundell	4	12 years, 3 months
714002	Provide BreakpadGetCrashReportCount() and -[BreakpadController getCrashReportCount:] (Closed)	kiyun	Mark Mentovai, qsr		12 years, 3 months
884002	disable unittests under ASAN that use memory crashes (Closed)	vapier	Lei Zhang (chromium), Ted Mielczarek, Ben Chan		12 years, 3 months
834003	Address additional comments from r1248. Fix the register to check and fix some style nits. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek	2	12 years, 3 months
824003	Conditionalize use of <cpuid.h> header (Closed)	Roland McGrath	Mark Mentovai		12 years, 3 months
864003	Use AM_MAINTAINER_MODE so configure supports --enable-maintainer-mode (Closed)	Roland McGrath	bradnelson, Mark Mentovai, Ted Mielczarek, mcgrathr		12 years, 3 months
619002	check for and enable Large File Support automatically (Closed)	vapier	Lei Zhang (chromium), Ted Mielczarek, Ben Chan		12 years, 3 months

« Newest ‹ Newer 221 - 240 Older ›