Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 455002: Add MMX detection when getting registers in Linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by aras.vaichas
Modified:
7 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

For CPUs that don't support the MMX instruction set, such pre-Pentium III or
industrial x86 embedded PCs, the minidump fails when it tries to retrieve MMX
specific registers.

This patch adds MMX detection for that call.

Tested on Ubuntu 12.04 with i686, and on a custom Linux distro on a Vortex86DX
microcontroller.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_ptrace_dumper.cc View 2 chunks +11 lines, -2 lines 3 comments Download

Messages

Total messages: 8
Ted Mielczarek
This LGTM, I'll land it as soon as I find out if you have a ...
8 years, 4 months ago #1
Lei Zhang (chromium)
lgtm You need to sign the Google CLA before we can accept this code: https://developers.google.com/open-source/cla/individual ...
7 years, 8 months ago #2
aras.vaichas
Google CLA has been signed off. Aras On 26 November 2013 23:49, <thestig@chromium.org> wrote: > ...
7 years, 7 months ago #3
Ted Mielczarek
On 2013/12/09 09:02:30, aras.vaichas wrote: > Google CLA has been signed off. thestig: can you ...
7 years, 7 months ago #4
aras.vaichas
I don't know what you mean by "land". Sorry, but I have no way to ...
7 years, 7 months ago #5
Lei Zhang (chromium)
On 2013/12/09 20:05:22, Ted Mielczarek wrote: > On 2013/12/09 09:02:30, aras.vaichas wrote: > > Google ...
7 years, 7 months ago #6
Lei Zhang (chromium)
On 2013/12/09 20:13:51, aras.vaichas wrote: > I don't know what you mean by "land". Land ...
7 years, 7 months ago #7
Lei Zhang (chromium)
7 years, 7 months ago #8
Feel free to Edit -> Close this issue since I have committed it for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted