Avoid redefinition of global static debug flag and remove unneeded GTMDefines.h"

Avoid redefinition of global static debug flag and remove unneeded GTMDefines.h"

[Mark Mentovai]

LGTM. r1244.

[mostynb]

I suspect that this change broke mac builds (from a roll attempt in
https://codereview.chromium.org/100923006/):

FAILED: clang++ -Wl,-search_paths_first -Wl,-pie -mmacosx-version-min=10.6
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-arch i386 -L. -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -o
crash_inspector
obj/breakpad/src/client/mac/crash_generation/crash_inspector.ConfigFile.o
obj/breakpad/src/client/mac/crash_generation/crash_inspector.Inspector.o
obj/breakpad/src/client/mac/crash_generation/crash_inspector.InspectorMain.o
libbreakpad_utilities.a  -framework CoreServices -framework Foundation &&
(export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/mac/build/src/out/Debug;
export CONFIGURATION=Debug; export EXECUTABLE_NAME=crash_inspector; export
EXECUTABLE_PATH=crash_inspector; export FULL_PRODUCT_NAME=crash_inspector;
export PRODUCT_NAME=crash_inspector; export
PRODUCT_TYPE=com.apple.product-type.tool; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/mac/build/src/out/Debug/../../breakpad;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/mac/build/src/out/Debug; export
TEMP_DIR="${TMPDIR}"; (cd ../../breakpad &&
../build/mac/change_mach_o_flags_from_xcode.sh); G=$?; ((exit $G) || rm -rf
crash_inspector) && exit $G)
Undefined symbols for architecture i386:
  "_gDebugLog", referenced from:
      google_breakpad::ConfigFile::AppendConfigData(char const*, void const*,
unsigned long) in crash_inspector.ConfigFile.o
      google_breakpad::ConfigFile::WriteFile(char const*,
google_breakpad::NonAllocatingMap<256ul, 256ul, 64ul> const*, char const*, char
const*) in crash_inspector.ConfigFile.o
      google_breakpad::Inspector::ReadMessages() in crash_inspector.Inspector.o
      google_breakpad::Inspector::InspectTask() in crash_inspector.Inspector.o
      google_breakpad::Inspector::SendAcknowledgement() in
crash_inspector.Inspector.o
      google_breakpad::Inspector::LaunchReporter(char const*) in
crash_inspector.Inspector.o
      google_breakpad::MinidumpLocation::MinidumpLocation(NSString*) in
crash_inspector.Inspector.o
      ...
      google_breakpad::ConfigFile::AppendConfigData(char const*, void const*,
unsigned long) in crash_inspector.ConfigFile.o
      google_breakpad::ConfigFile::WriteFile(char const*,
google_breakpad::NonAllocatingMap<256ul, 256ul, 64ul> const*, char const*, char
const*) in crash_inspector.ConfigFile.o
      google_breakpad::Inspector::ReadMessages() in crash_inspector.Inspector.o
      google_breakpad::Inspector::InspectTask() in crash_inspector.Inspector.o
      google_breakpad::Inspector::SendAcknowledgement() in
crash_inspector.Inspector.o
      google_breakpad::Inspector::LaunchReporter(char const*) in
crash_inspector.Inspector.o
      google_breakpad::MinidumpLocation::MinidumpLocation(NSString*) in
crash_inspector.Inspector.o
      ...
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

[Mark Mentovai]

I backed out r1244 at r1247.

Alistair, you switched this to use Inspector.h which says “extern bool
gDebugLog”, but there’s no extern symbol named gDebugLog anywhere after you
remove it from ConfigFile.mm. There are only static symbols by this name, which
aren’t visible from ConfigFile.mm or Inspector.mm.

[altse_google.com]

Sorry for breaking the build.

I see what the problem is and my expectation that extern bool gDebugLog was
an extern static. Thanks for backing the change out. I'll take a look at
this again to see if there's a better way to resolve these multiple
gDebugLog statics (and non-statics) that I'm seeing.


On Mon, Dec 9, 2013 at 9:10 AM, <mark@chromium.org> wrote:

> I backed out r1244 at r1247.
>
> Alistair, you switched this to use Inspector.h which says “extern bool
> gDebugLog”, but there’s no extern symbol named gDebugLog anywhere after
> you remove it from ConfigFile.mm. There are only static symbols by this
> name, which aren’t visible from ConfigFile.mm or Inspector.mm.
>
> https://breakpad.appspot.com/824002/
>

[Mark Mentovai]

And sorry for misspelling your name.