Fix gcc vs clang cpuid.h discrepency.

Fix gcc vs clang cpuid.h discrepency.

For r1254, gcc defines bit_FXSAVE while clang defines bit_FXSR.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1260

[Lei Zhang (chromium)]

I wonder if Clang should make its cpuid.h gcc compatible.

[Mark Mentovai]

LGTM

https://breakpad.appspot.com/924002/diff/1/src/client/linux/minidump_writer/l...
File src/client/linux/minidump_writer/linux_ptrace_dumper.cc (right):

https://breakpad.appspot.com/924002/diff/1/src/client/linux/minidump_writer/l...
src/client/linux/minidump_writer/linux_ptrace_dumper.cc:198: #if defined
(__clang__)
#ifndef bit_FXSAVE instead?

[thakis]

Looks like this is a bug in the gcc headers that they don't want to fix:
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02158.html :-(

[Lei Zhang (chromium)]

https://breakpad.appspot.com/924002/diff/1/src/client/linux/minidump_writer/l...
File src/client/linux/minidump_writer/linux_ptrace_dumper.cc (right):

https://breakpad.appspot.com/924002/diff/1/src/client/linux/minidump_writer/l...
src/client/linux/minidump_writer/linux_ptrace_dumper.cc:198: #if defined
(__clang__)
On 2013/12/14 13:56:27, Mark Mentovai wrote:
> #ifndef bit_FXSAVE instead?

Done.

[Lei Zhang (chromium)]

Committed patchset #2 manually as r1260 (presubmit successful).

[thakis]

http://llvm.org/viewvc/llvm-project?view=revision&revision=197399

Hopefully, this can be removed again soon.


On Sat, Dec 14, 2013 at 11:17 AM, <thestig@chromium.org> wrote:

> Committed patchset #2 manually as r1260 (presubmit successful).
>
> https://breakpad.appspot.com/924002/
>

[Lei Zhang (chromium)]

Maybe. If we remove it, I suspect someone somewhere will still be using an older
version of Clang and complain.

On 2013/12/16 18:09:23, thakis wrote:
> http://llvm.org/viewvc/llvm-project?view=revision&revision=197399
> 
> Hopefully, this can be removed again soon.
> 
> 
> On Sat, Dec 14, 2013 at 11:17 AM, <mailto:thestig@chromium.org> wrote:
> 
> > Committed patchset #2 manually as r1260 (presubmit successful).
> >
> > https://breakpad.appspot.com/924002/
> >