Misc Android-related fixes.

Misc Android-related fixes.

- src/common/android/testing/mkdtemp.h:
  Fixes a compilation error when using the (recent) NDK r9b,
  see comments in the source file for details.

- android/test-driver, Makefile.am, Makefile.in:
  Autotools 1.12 changed the way tests are run during "make check"
  so add a new "custom test driver" to run tests on Android, and
  modify Makefile.am / Makefile.in accordingly. Otherwise,
  'make check' tried to run the tests on the host.

- android/test-shell.sh:
  Allow several tests to run in parallel on the device, by
  creating a custom test directory for each test process.
  This allows running "make check -j8" reliably.

- src/common/linux/file_id_unittest.cc:
  Disable the SelfStrip test on Android, since it assumes a 'strip'
  executable is available on the target system where the test runs.

BUG=NONE
R=mark@chromium.org, ted.mielczarek@gmail.com
TEST=android/run-checks.sh --ndk-dir=/path/to/android-ndk-r9b

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1259

[Mark Mentovai]

https://breakpad.appspot.com/904003/diff/1/android/test-driver
File android/test-driver (right):

https://breakpad.appspot.com/904003/diff/1/android/test-driver#newcode98
android/test-driver:98: $(dirname "$0")/test-shell.sh "$@" > $log_file 2>&1
Needs more quotes:

"$(dirname "$0")/test-shell.sh" "$@" > $log_file 2>&1

https://breakpad.appspot.com/904003/diff/1/android/test-shell.sh
File android/test-shell.sh (right):

https://breakpad.appspot.com/904003/diff/1/android/test-shell.sh#newcode56
android/test-shell.sh:56: adb_shell mkdir "$TEST_DIR" || panic "Can't create
test directory on device: $TEST_DIR"
This goes past 80 columns. Wrap it.

https://breakpad.appspot.com/904003/diff/1/src/common/android/testing/mkdtemp.h
File src/common/android/testing/mkdtemp.h (right):

https://breakpad.appspot.com/904003/diff/1/src/common/android/testing/mkdtemp...
src/common/android/testing/mkdtemp.h:31: // packaging bug (the function has
always been implemented in all versions
Oh, so it’s just a missing declaration?

Is there a macro that has the NDK version?

If so, this header can just detect mkdtemp-declaration-less NDK versions and
provide its own declaration in that case. It can do nothing when building with
an NDK that does declare it.

[digit]

https://breakpad.appspot.com/904003/diff/1/android/test-driver
File android/test-driver (right):

https://breakpad.appspot.com/904003/diff/1/android/test-driver#newcode98
android/test-driver:98: $(dirname "$0")/test-shell.sh "$@" > $log_file 2>&1
On 2013/12/13 14:24:28, Mark Mentovai wrote:
> Needs more quotes:
> 
> "$(dirname "$0")/test-shell.sh" "$@" > $log_file 2>&1

Done.

https://breakpad.appspot.com/904003/diff/1/android/test-shell.sh
File android/test-shell.sh (right):

https://breakpad.appspot.com/904003/diff/1/android/test-shell.sh#newcode56
android/test-shell.sh:56: adb_shell mkdir "$TEST_DIR" || panic "Can't create
test directory on device: $TEST_DIR"
On 2013/12/13 14:24:28, Mark Mentovai wrote:
> This goes past 80 columns. Wrap it.

Done.

https://breakpad.appspot.com/904003/diff/1/src/common/android/testing/mkdtemp.h
File src/common/android/testing/mkdtemp.h (right):

https://breakpad.appspot.com/904003/diff/1/src/common/android/testing/mkdtemp...
src/common/android/testing/mkdtemp.h:31: // packaging bug (the function has
always been implemented in all versions
Yes, just a missing declaration. There is no macro detailing the NDK revision.

I didn't want to add some auto-detection magic through configure.ac, because
this is only for testing, and we should be able to get rid of it soon.

(I've also tested you could remove this header, and that the tests run when
built with NDK r9b, but this is for a later patch I think).

[Mark Mentovai]

LGTM then. The comment you left in the header saying that it can be removed in
the future is enough.

[digit]

Thanks

[digit]

Committed patchset #2 manually as r1259 (presubmit successful).