Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Open Issues

‹ Newer 21 - 40 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
9714003	Fix breakpad on mips and x86_64 for the NDK r10c update.	fdegans	primiano, Mark Mentovai, anton, anton1, pasko, casinobong88	12	11 years, 7 months
2774002	Add memory map permissions to Linux mapping information	arjanl	rmcilroy, Lei Zhang (chromium), casinobong88		11 years, 7 months
1624002	Add flags to control the amount of information written to Linux minidump files	Pedro Navarro	Lei Zhang (chromium), Ted Mielczarek, casinobong88	17	11 years, 7 months
7764002	Update project to include microdump.	Jess	ivanpe, Mark Mentovai, Ted Mielczarek, primiano		11 years, 9 months
1774002	Breakpad: Fix build with new clang versions.	thakis	Mark Mentovai		11 years, 9 months
4694002	Win32 build fixes	zomps0	jturney	1	11 years, 10 months
3734002	Workaround WIN32 compile error C2039: '_exception_code' : is not a member of 'MDException'	zomps0			11 years, 10 months
6784002	MSVC 2013 build fix: error C2036: 'void *' : unknown size	zomps0			11 years, 10 months
2804002	Linux ELF core tests: kernel.core_use_pid also affects core filename	Jed Davis			11 years, 11 months
4674002	dwarf: Minimal support for DWARF expressions	mdempsky	Lei Zhang (chromium), jimb	14	11 years, 11 months
5694002	Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd.	joleksy	Mark Mentovai		11 years, 12 months
4664002	Set 32 bits iOS app to use vm_region_recurse_64.	olivierrobin	blundell, Mark Mentovai		12 years
2744002	Annotate PageAllocator for MSan.	earthdok	Mark Mentovai		12 years, 1 month
2724002	[NOT FOR REVIEW] Prototype to generate microdumps in logcat.	primiano			12 years, 2 months
1684002	Allow build on VS2010 and VS2012	mkato	Ted Mielczarek	1	12 years, 2 months
7674002	Fix compilation error in Linux libc++ builds due to use of tr1/.	earthdok	Mark Mentovai	4	12 years, 2 months
2714002	dump_syms: use unordered_set<> instead of set<> for speed.	uekawa	Mark Mentovai, earthdok	2	12 years, 2 months
600002	blocking on sys_wait	issac.xwork	Ted Mielczarek, Lei Zhang (chromium), thestig1, Mark Mentovai	4	12 years, 3 months
6664002	minidump_dump: Display x86 CPU vendor string for x86_64	Mark Mentovai	Ted Mielczarek		12 years, 3 months
5654002	Fix various FD leaks and handle errors better	mdempsky	rsesek		12 years, 4 months

‹ Newer 21 - 40 Older ›