Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 1684002: Allow build on VS2010 and VS2012

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by mkato
Modified:
6 years, 11 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allow build on VS2010 and VS2012

BUG=584

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/windows/pdb_source_line_writer.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 1
Ted Mielczarek
6 years, 11 months ago #1
https://breakpad.appspot.com/1684002/diff/1/src/common/windows/pdb_source_lin...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/1684002/diff/1/src/common/windows/pdb_source_lin...
src/common/windows/pdb_source_line_writer.cc:43: #undef max
Can't we #define NOMINMAX instead?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted