Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 2804002: Linux ELF core tests: kernel.core_use_pid also affects core filename

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Jed Davis
Modified:
6 years, 8 months ago
Reviewers:
CC:
Ted Mielczarek, google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Two of the tests (LinuxCoreDumperTest.VerifyDumpWithMultipleThreads and
ElfCoreDumpTest.ValidCoreFile) would fail if the sysctl variable
kernel.core_use_pid was set to 1, because they depend on the filename of a
native core dump being "core" (not "core.%d" with the pid).  There's already a
check for the more general kernel.core_pattern facility which skips the test if
the name is changed, so this patch adds core_use_pid to it.

I notice that there doesn't seem to be any visible warning if the test is
skipped for this reason.  Should I try to fix that?  (And, if so, pointers to
how to make that happen?)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/tests/crash_generator.cc View 1 chunk +3 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted