Issue 4664002: Set 32 bits iOS app to use vm_region_recurse_64.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 4664002: Set 32 bits iOS app to use vm_region_recurse_64.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by olivierrobin

Modified:
9 years, 8 months ago

Reviewers:
blundell, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Set 32 bits iOS app to use vm_region_recurse_64.

Using the vm_region_recurse API with a vm_region_submap_info_64 
structure leads to a deviation in the structure when reading the user_tag
field.
Switching to the vm_region_recurse_64 API.

BUG=crbug/397133

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/mac/handler/mach_vm_compat.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

blundell

Please add context on the reasons for this change for the benefit of anyone looking ...

9 years, 8 months ago #1

olivierrobin

On 2014/08/11 12:26:20, blundell wrote: > LGTM Thanks. How can I push the change ?

9 years, 8 months ago #4

Landed as r1363. You'll have to close the issue yourself.

Expand All Messages | Collapse All Messages