Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(143)

Issue 4664002: Set 32 bits iOS app to use vm_region_recurse_64.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by olivierrobin
Modified:
3 years, 1 month ago
Reviewers:
blundell, Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Set 32 bits iOS app to use vm_region_recurse_64.

Using the vm_region_recurse API with a vm_region_submap_info_64 
structure leads to a deviation in the structure when reading the user_tag
field.
Switching to the vm_region_recurse_64 API.

BUG=crbug/397133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/mach_vm_compat.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
blundell
Please add context on the reasons for this change for the benefit of anyone looking ...
3 years, 1 month ago #1
Mark Mentovai
LGTM
3 years, 1 month ago #2
blundell
LGTM
3 years, 1 month ago #3
olivierrobin
On 2014/08/11 12:26:20, blundell wrote: > LGTM Thanks. How can I push the change ?
3 years, 1 month ago #4
blundell
3 years, 1 month ago #5
Landed as r1363. You'll have to close the issue yourself.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted