Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 61 - 80 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
4684002	Microdumps: refactor out common parts of minidump_writer.cc (Closed)	primiano	Mark Mentovai, mmandlis	6	11 years, 7 months
1734002	Fix some nits raised by Timur for r1385. (Closed)	Lei Zhang (chromium)	ivanpe		11 years, 7 months
6744002	IWYU in minidump_writer.cc to fix building with libc++ after r1385. (Closed)	Lei Zhang (chromium)	ivanpe		11 years, 7 months
5734002	Linux: Call memset() in a couple places in ExceptionHandler to avoid uninit memory reads under Valg… (Closed)	Lei Zhang (chromium)	ivanpe		11 years, 7 months
5724002	Fix clang compilation error introduced in r1380. (Closed)	simonb	rmcilroy		11 years, 7 months
7714003	Extend mapping merge to include reserved but unused mappings. (Closed)	simonb	Lei Zhang (chromium), rmcilroy, Ted Mielczarek		11 years, 7 months
6734002	Add inttypes for windows in dump_context (Closed)	mmandlis	primiano		11 years, 7 months
7714002	GoogleCrashdumpUploader: adds Upload(string*) API to get the HTTP response. (Closed)	gunsch	Mark Mentovai, lcwu	7	11 years, 7 months
8674002	Fixes common_unittests build. (Closed)	Lei Zhang (chromium)	gunsch		11 years, 7 months
7704002	Fix Windows client unittests build: add missing code files (Closed)	mmandlis	Mark Mentovai, ivanpe		11 years, 7 months
4654002	Fixing a build break on Linux. (Closed)	mmandlis	ivanpe		11 years, 7 months
6714002	Making the Mac build of crash_report work again after the last SVN sync (Closed)	mmandlis	ivanpe, tschweitzer		11 years, 7 months
1714002	Mac: Add support for in-process crash reporting to Breakpad. (Closed)	andresantoso	Mark Mentovai		11 years, 7 months
2764002	Adding possibility for client to upload the file (Closed)	olivierrobin	qsr, blundell, pkl, Mark Mentovai, mmandlis	53	11 years, 7 months
2794002	This CL initialize NSData in HTTPMultipartUpload.m to nil. (Closed)	olivierrobin	blundell, qsr		11 years, 7 months
9704002	Update processor.gyp file with new files added as part of microdump processing upcoming implementat… (Closed)	mmandlis	primiano, Mark Mentovai	3	11 years, 7 months
5684002	Refactoring in preparation for microdump processing (Closed)	mmandlis	primiano, Mark Mentovai	29	11 years, 7 months
2784002	Introduce stub microdump processor classes. (Closed)	mmandlis	primiano	15	11 years, 7 months
9694002	Back out trunk r1367 (Closed)	Mark Mentovai	primiano, Ted Mielczarek		11 years, 8 months
10684002	upload_system_symbols: Use the Go1.3 improvements to debug/macho. (Closed)	rsesek	andybons, Mark Mentovai	4	11 years, 9 months

« Newest ‹ Newer 61 - 80 Older ›