Update processor.gyp file with new files added as part of microdump processing upcoming implementat…

Update processor.gyp file with new files added as part of microdump processing
upcoming implementation.

dump_context.cc and dump_object.cc added in r/1370
microdump_processor.cc and microdump_processor_unittest.cc added in r/1372

BUG=chromium:410294

[Mark Mentovai]

LGTM ☺

[primiano]

LGTM % 1 nit.
Also please keep the first line of the commit message <= 72 cols and wrap the
rest accordingly.

On a side note, I have the suspicion that nobody has been building the
processor_unittests target in a while. Even without this CL, there is definitely
more than one file for that target which provides a definition of main(). I bet
that target will fail with a "redefinition of main" linker error i built ;-)
On the more practical side, I don't think it's a priority to fix right now. It
seems to have been in this state for a while.

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp
File src/processor/processor.gyp (right):

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp#newco...
src/processor/processor.gyp:55: 'dump_context.cc',
For sake of consistency you should also add the .h files here.
Rationale: it is not going to make a difference for the ninja generator (for
building), but other gyp generators (VStudio, Xcode) use it to add all the
relevant files to the IDE.

[mmandlis]

Unfortunately I already submitted this after Mark approved.
I'll put together a new CL that adds the .h files. Sorry for my negligence (

On 2014/09/10 22:48:37, primiano wrote:
> LGTM % 1 nit.
> Also please keep the first line of the commit message <= 72 cols and wrap the
> rest accordingly.
> 
> On a side note, I have the suspicion that nobody has been building the
> processor_unittests target in a while. Even without this CL, there is
definitely
> more than one file for that target which provides a definition of main(). I
bet
> that target will fail with a "redefinition of main" linker error i built ;-)
> On the more practical side, I don't think it's a priority to fix right now. It
> seems to have been in this state for a while.
> 
> https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp
> File src/processor/processor.gyp (right):
> 
>
https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp#newco...
> src/processor/processor.gyp:55: 'dump_context.cc',
> For sake of consistency you should also add the .h files here.
> Rationale: it is not going to make a difference for the ninja generator (for
> building), but other gyp generators (VStudio, Xcode) use it to add all the
> relevant files to the IDE.

[mmandlis]

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp
File src/processor/processor.gyp (right):

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp#newco...
src/processor/processor.gyp:55: 'dump_context.cc',
On 2014/09/10 22:48:37, primiano wrote:
> For sake of consistency you should also add the .h files here.
> Rationale: it is not going to make a difference for the ninja generator (for
> building), but other gyp generators (VStudio, Xcode) use it to add all the
> relevant files to the IDE.

Actually, looking into it again, here are only the .h files that are under
src/processor/, when all the .h files I added are under
src/google_breakpad/processor. I couldn't find any .gyp file that lists them, is
there one?

[primiano]

Change committed as r1373

https://code.google.com/p/google-breakpad/source/detail?r=1373

[primiano]

> Unfortunately I already submitted this after Mark approved
Ah, don't worry, it's not really worth another CL.

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp
File src/processor/processor.gyp (right):

https://breakpad.appspot.com/9704002/diff/1/src/processor/processor.gyp#newco...
src/processor/processor.gyp:55: 'dump_context.cc',
On 2014/09/11 00:49:54, mmandlis wrote:
> On 2014/09/10 22:48:37, primiano wrote:
> > For sake of consistency you should also add the .h files here.
> > Rationale: it is not going to make a difference for the ninja generator (for
> > building), but other gyp generators (VStudio, Xcode) use it to add all the
> > relevant files to the IDE.
> 
> Actually, looking into it again, here are only the .h files that are under
> src/processor/, when all the .h files I added are under
> src/google_breakpad/processor. I couldn't find any .gyp file that lists them,
is
> there one?

Ah nevermind, I didn't realize that.
Let's leave it as it is so.