upload_system_symbols: Use the Go1.3 improvements to debug/macho.

upload_system_symbols: Use the Go1.3 improvements to debug/macho.

This removes the custom MachO header reading functionality, since the stdlib can
now read Fat files.

R=andybons@chromium.org, mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1360

[andybons]

lgtm pending mr. mentovai

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
File src/tools/mac/upload_system_symbols/arch_reader.go (right):

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
src/tools/mac/upload_system_symbols/arch_reader.go:42: // This function is a Go
version of src/common/mac/arch_utilities.cc:BreakpadGetArchInfoFromCpuType().
func comments start with the function name...

// getArchStringFromHeader blah blah blah...

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
src/tools/mac/upload_system_symbols/arch_reader.go:46: return "arm64"
constants?

[rsesek]

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
File src/tools/mac/upload_system_symbols/arch_reader.go (right):

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
src/tools/mac/upload_system_symbols/arch_reader.go:42: // This function is a Go
version of src/common/mac/arch_utilities.cc:BreakpadGetArchInfoFromCpuType().
On 2014/07/31 18:30:06, andybons wrote:
> func comments start with the function name...
> 
> // getArchStringFromHeader blah blah blah...

Done.

https://breakpad.appspot.com/10684002/diff/1/src/tools/mac/upload_system_symb...
src/tools/mac/upload_system_symbols/arch_reader.go:46: return "arm64"
On 2014/07/31 18:30:06, andybons wrote:
> constants?

I thought about it, but decided against because the strings returned from
GetNXArchInfoName() don't have constants (nor do they need them).

[Mark Mentovai]

LGTM

[rsesek]

Committed patchset #2 manually as 1360 (presubmit successful).