Introduce stub microdump processor classes.

Introduce stub microdump processor classes.

Adds the interfaces for MicrodumpProcessor (very similar to
MinidumpProcessor) and corresponding unittest stubs.
These stubs are required for multi-side integration and to start
rolling the updated processor library into the dependent projects.

BUG=chromium:410294

[mmandlis]

This is just an interface and an empty implementation.
The change builds and tests pass.

Please, take a look.

Thanks!

[primiano]

Looks almost good, I have only few comments.
I'd reword slightly the commit message, maybe something like this:


Introduce stub microdump processor classes.

Adds the interfaces for MicrodumpProcessor (very similar to
MinidumpProcessor) and corresponding unittest stubs.
These stubs are required for multi-side integration and to start
rolling the updated processor library into the dependent projects.

BUG=chromium:410294

https://breakpad.appspot.com/2784002/diff/1/Makefile.am
File Makefile.am (right):

https://breakpad.appspot.com/2784002/diff/1/Makefile.am#newcode167
Makefile.am:167: src/google_breakpad/processor/microdump_processor.h \
Nit: the indentation seems wrong here. add more spaces (here and below) :)

https://breakpad.appspot.com/2784002/diff/1/Makefile.am#newcode776
Makefile.am:776: src/processor/call_stack.o \
Do you already know you'll need these objects in the next CL?
I'd prefer to add this .o files unless you actually need them in this CL.

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
File src/google_breakpad/processor/microdump_processor.h (right):

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
src/google_breakpad/processor/microdump_processor.h:36: #include
"google_breakpad/common/breakpad_types.h"
Probably you don't need this include here.

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
src/google_breakpad/processor/microdump_processor.h:53:
google_breakpad::ProcessResult Process(const string &microdump_contents,
nit: move the & near to string (i.e. const string& microdump_content) ?

I realize that the spacing (& adjacent to the type vs the arg name) is very
inconsistent in breakpad (33 string& vs 87 string &). In doubt, let's stick with
chromium style :)

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor.cc
File src/processor/microdump_processor.cc (right):

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor.cc:52: assert(process_state);
Can you add something like:
TODO(mmandlis): Implement MicrodumpProcessor. See crbug.com/410294

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
File src/processor/microdump_processor_unittest.cc (right):

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor_unittest.cc:38: #include
"google_breakpad/processor/call_stack.h"
I'd remove these includes (you're not using them at the moment) and readd them
when you will actually need them.

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor_unittest.cc:49: ASSERT_TRUE(true);
I think you can remove this test entirelly at the moment and leave just the stub
class (or is there something checking that you have at least one test?).

Also, please add a TODO like the one I suggested above, so people who open this
file in the meanwhile will not be surprised :)

[mmandlis]

Addressed comments, PTAL.

Thanks!

https://breakpad.appspot.com/2784002/diff/1/Makefile.am
File Makefile.am (right):

https://breakpad.appspot.com/2784002/diff/1/Makefile.am#newcode167
Makefile.am:167: src/google_breakpad/processor/microdump_processor.h \
On 2014/09/10 09:16:16, primiano wrote:
> Nit: the indentation seems wrong here. add more spaces (here and below) :)

Done.

PS: Saw this meme https://memegen.googleplex.com/4599800408309760 yesterday, and
decided to try using eclipse instead ))

https://breakpad.appspot.com/2784002/diff/1/Makefile.am#newcode776
Makefile.am:776: src/processor/call_stack.o \
On 2014/09/10 09:16:16, primiano wrote:
> Do you already know you'll need these objects in the next CL?
> I'd prefer to add this .o files unless you actually need them in this CL.

Done.

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
File src/google_breakpad/processor/microdump_processor.h (right):

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
src/google_breakpad/processor/microdump_processor.h:36: #include
"google_breakpad/common/breakpad_types.h"
On 2014/09/10 09:16:16, primiano wrote:
> Probably you don't need this include here.

Done.

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
src/google_breakpad/processor/microdump_processor.h:36: #include
"google_breakpad/common/breakpad_types.h"
On 2014/09/10 09:16:16, primiano wrote:
> Probably you don't need this include here.

Done.

https://breakpad.appspot.com/2784002/diff/1/src/google_breakpad/processor/mic...
src/google_breakpad/processor/microdump_processor.h:53:
google_breakpad::ProcessResult Process(const string &microdump_contents,
On 2014/09/10 09:16:16, primiano wrote:
> nit: move the & near to string (i.e. const string& microdump_content) ?
> 
> I realize that the spacing (& adjacent to the type vs the arg name) is very
> inconsistent in breakpad (33 string& vs 87 string &). In doubt, let's stick
with
> chromium style :)

Done.

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor.cc
File src/processor/microdump_processor.cc (right):

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor.cc:52: assert(process_state);
On 2014/09/10 09:16:16, primiano wrote:
> Can you add something like:
> TODO(mmandlis): Implement MicrodumpProcessor. See crbug.com/410294

Done.

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
File src/processor/microdump_processor_unittest.cc (right):

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor_unittest.cc:38: #include
"google_breakpad/processor/call_stack.h"
On 2014/09/10 09:16:16, primiano wrote:
> I'd remove these includes (you're not using them at the moment) and readd them
> when you will actually need them.

Done.

https://breakpad.appspot.com/2784002/diff/1/src/processor/microdump_processor...
src/processor/microdump_processor_unittest.cc:49: ASSERT_TRUE(true);
On 2014/09/10 09:16:16, primiano wrote:
> I think you can remove this test entirelly at the moment and leave just the
stub
> class (or is there something checking that you have at least one test?).
> 
> Also, please add a TODO like the one I suggested above, so people who open
this
> file in the meanwhile will not be surprised :)

Done.

[primiano]

LGTM

[primiano]

Change committed as r1372

https://code.google.com/p/google-breakpad/source/detail?r=1372