Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Delta Between Two Patch Sets: src/processor/microdump_processor_unittest.cc

Issue 2784002: Introduce stub microdump processor classes. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Left Patch Set: Created 10 years, 7 months ago
Right Patch Set: Address comments: Remove excessive includes, add TODOs, fix indentation, etc Created 10 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/processor/microdump_processor.cc ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // Copyright (c) 2014, Google Inc. 1 // Copyright (c) 2014, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 29
30 // Unit test for MicrodumpProcessor. 30 // Unit test for MicrodumpProcessor.
31 31
32 #include <stdlib.h>
33
34 #include <string>
35
36 #include "breakpad_googletest_includes.h" 32 #include "breakpad_googletest_includes.h"
37 #include "common/using_std_string.h"
38 #include "google_breakpad/processor/call_stack.h"
primiano 2014/09/10 09:16:16 I'd remove these includes (you're not using them a
mmandlis 2014/09/10 18:07:18 Done.
39 #include "google_breakpad/processor/microdump_processor.h"
40 #include "google_breakpad/processor/process_state.h"
41 #include "processor/logging.h"
42 33
43 namespace { 34 namespace {
44 35
45 class MicrodumpProcessorTest : public ::testing::Test { 36 class MicrodumpProcessorTest : public ::testing::Test {
46 }; 37 };
47 38
48 TEST_F(MicrodumpProcessorTest, TestEmpty) { 39 // TODO(mmandlis): Add MicrodumpProcessor tests. See crbug.com/410294
49 ASSERT_TRUE(true);
primiano 2014/09/10 09:16:16 I think you can remove this test entirelly at the
mmandlis 2014/09/10 18:07:18 Done.
50 }
51 40
52 } // namespace 41 } // namespace
53 42
54 int main(int argc, char *argv[]) { 43 int main(int argc, char *argv[]) {
55 ::testing::InitGoogleTest(&argc, argv); 44 ::testing::InitGoogleTest(&argc, argv);
56 return RUN_ALL_TESTS(); 45 return RUN_ALL_TESTS();
57 } 46 }
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted