Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 201 - 220 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
320001	Merge trunk r875 to the chrome_15 branch (Closed)	Mark Mentovai	Lei Zhang (chromium)		11 years, 8 months
299001	Allow specifications to refer to other specifications that follow them in (Closed)	Mark Mentovai	Ted Mielczarek, jimb, qsr	9	11 years, 8 months
744002	In iOS, BREAKPAD_OUTPUT_DUMP_FILE value contains a malformed full path to the dump file (Closed)	Akiva	qsr, markus, Lei Zhang (chromium), aurisanchez2	3	11 years, 8 months
664002	Generate minidumps for 64-bit ARM apps on iOS. (Closed)	blundell	Mark Mentovai, qsr	93	11 years, 8 months
644002	Augment mach_vm_compat.h to support compiling for 64-bit on iOS. (Closed)	blundell	qsr		11 years, 8 months
744003	Test upload again. (Closed)	scr			11 years, 8 months
754002	Allow SIGABRT to abort the program. (Closed)	Lei Zhang (chromium)	semenzato		11 years, 9 months
694002	Fix the .raSearchStart calculation (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, bsmedberg, Jess	4	11 years, 9 months
674003	NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args) (Closed)	Mark Mentovai	mochalatte, thakis	2	11 years, 9 months
654002	Add SIGTRAP to the handled signals on Linux (Closed)	jochen	Mark Mentovai		11 years, 9 months
684002	Warning on unused const variable. (Closed)	yunlian1	vapier, Ben Chan		11 years, 9 months
674002	Use scoped_array instead of inappropriate scoped_ptr (Closed)	Jess	Ivan Penkov, ivanpe.google, Lei Zhang (chromium)		11 years, 9 months
636002	increase exception handler stack size for dumping thread (Closed)	vapier	Ted Mielczarek, Ben Chan		11 years, 9 months
643002	Remove define of mach_vm_region from mach_vm_compatibility.h. (Closed)	blundell	qsr		11 years, 9 months
642002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		11 years, 9 months
639002	Support symbol dumping for ARMV8 iOS apps. (Closed)	blundell	Mark Mentovai, qsr		11 years, 9 months
640002	Remove unittest from sources list of iOS client xcodeproj. (Closed)	blundell	qsr		11 years, 9 months
596002	Always read CFI section, even when not outputing CFI information. (Closed)	qsr	Mark Mentovai, Ted Mielczarek, blundell	1	11 years, 9 months
637004	Fix missing include in ios_exception_minidump_generator.mm (Closed)	blundell	qsr		11 years, 9 months
634002	Fix for failing mips stackwalker unittest. (Closed)	gordanac	digit, Mark Mentovai, Ivan Penkov		11 years, 10 months

« Newest ‹ Newer 201 - 220 Older ›