Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 241 - 260 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
864002	Add MMX detection when getting registers in Linux. (Closed)	Lei Zhang (chromium)	Ted Mielczarek, aras.vaichas, Mark Mentovai	4	12 years, 4 months
874002	Fix Windows release build error due to unreferenced variables. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Erik Wright		12 years, 4 months
844002	switch armv7 setting to arm_version==7 in breakpad (Closed)	mostynb	Mark Mentovai		12 years, 4 months
641002	Do not read CFI section when not outputing CFI information. (Closed)	qsr	Ted Mielczarek, Mark Mentovai		12 years, 4 months
704002	Process minidumps generated on ARM64 in iOS apps. (Closed)	blundell	Mark Mentovai, Ted Mielczarek	48	12 years, 4 months
814002	Fix unused method warning. (Closed)	Ivan Penkov	Mark Mentovai, blundell, Jess		12 years, 4 months
794002	Fixing several instances of wrong printf format specifiers. (Closed)	Ivan Penkov	Mark Mentovai, blundell, Jess		12 years, 4 months
804002	Add missing #include of eintr_wrapper.h to auto_testfile.h (Closed)	Mark Mentovai	blundell		12 years, 4 months
784002	Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close (Closed)	Mark Mentovai	Ted Mielczarek		12 years, 4 months
774002	Re-enable ios_exception_minidump_generator being built on non-ARM. (Closed)	blundell	Mark Mentovai		12 years, 4 months
320001	Merge trunk r875 to the chrome_15 branch (Closed)	Mark Mentovai	Lei Zhang (chromium)		12 years, 4 months
299001	Allow specifications to refer to other specifications that follow them in (Closed)	Mark Mentovai	Ted Mielczarek, jimb, qsr	9	12 years, 4 months
744002	In iOS, BREAKPAD_OUTPUT_DUMP_FILE value contains a malformed full path to the dump file (Closed)	Akiva	qsr, markus, Lei Zhang (chromium), aurisanchez2	3	12 years, 4 months
664002	Generate minidumps for 64-bit ARM apps on iOS. (Closed)	blundell	Mark Mentovai, qsr	93	12 years, 4 months
644002	Augment mach_vm_compat.h to support compiling for 64-bit on iOS. (Closed)	blundell	qsr		12 years, 4 months
744003	Test upload again. (Closed)	scr			12 years, 4 months
754002	Allow SIGABRT to abort the program. (Closed)	Lei Zhang (chromium)	semenzato		12 years, 5 months
734002	Allow SIGABRT to abort the program.	semenzato	markus, Lei Zhang (chromium)		12 years, 5 months
694002	Fix the .raSearchStart calculation (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, bsmedberg, Jess	4	12 years, 5 months
724002	Add support for configuring the minimum log level at compile time	jochen	Mark Mentovai		12 years, 5 months

« Newest ‹ Newer 241 - 260 Older ›