Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 641002: Do not read CFI section when not outputing CFI information. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by qsr
Modified:
10 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com, blundell
Base URL:
https://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Do not read CFI section when not outputing CFI information.

This revert revision 1182 and fix setting the module load address
whether CFI information is needed or not.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/mac/dump_syms.mm View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 5
qsr
Thanks to blundell@chromium.org for going back to this issue and finding the problem.
10 years, 7 months ago #1
Mark Mentovai
I missed this review request while on vacation. Do we still want this?
10 years, 5 months ago #2
qsr
On 2013/12/03 22:46:33, Mark Mentovai wrote: > I missed this review request while on vacation. ...
10 years, 5 months ago #3
Mark Mentovai
Yes, then LGTM. Wasn’t sure if you had found another way to achieve the same ...
10 years, 5 months ago #4
qsr
10 years, 5 months ago #5
Message was sent while issue was closed.
Committed patchset #1 manually as r1243 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted