Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 734002: Allow SIGABRT to abort the program.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by semenzato
Modified:
7 years, 8 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allow SIGABRT to abort the program.

SIGABRT can be generated internally, usually by calling abort(),
or externally by another process.  When the signal is generated
by the kernel, info->si_pid is 0 and the signal is treated in the
same way as an exception (SIGSEGV, etc.), but the assumption
that the exception happens again upon return from the handler
is wrong, so we must have a special case for this.

BUG=crbug.com/303075
TEST=tested with Alt-VolumeUp-X on Chrome OS

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/handler/exception_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
semenzato
I don't know who the good reviewers might be, so please add yourself. Thank you ...
7 years, 8 months ago #1
semenzato
I should add: I have examined all uses of SIGABRT/SIGIOT in the kernel for various ...
7 years, 8 months ago #2
markus
LGTM, but I am not sure I am the best reviewer for breakpad code.
7 years, 8 months ago #3
semenzato
Thank you! Can you suggest another reviewer? On Thu, Nov 7, 2013 at 11:21 AM, ...
7 years, 8 months ago #4
markus
I usually defer to thestig for anything related to breakpad
7 years, 8 months ago #5
Lei Zhang (chromium)
lgtm
7 years, 8 months ago #6
semenzato
7 years, 8 months ago #7
On 2013/11/07 21:39:47, thestig wrote:
> lgtm

Thank you!

Do I have permissions to commit, and how would I do that?  I tried "gcl commit
<name>" but:

svn: Commit failed (details follow):
svn: Server sent unexpected return value (405 Method Not Allowed) in response to
MKACTIVITY request for '/svn/!svn/act/f282c9b9-ce45-4314-8ebb-4fb6e51c946d'
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted