Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 41 - 60 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
9734002	Add parameter --product to symupload.exe (Closed)	ivanpe	Mark Mentovai, Ted Mielczarek, mmandlis		10 years, 4 months
9684002	[Linux] Force dump_syms to always read public symbols (Closed)	walac	Ted Mielczarek, Lei Zhang (chromium)	8	10 years, 5 months
9724002	Fix UMR and potential crash in Mac dump_syms. (Closed)	rsesek	Mark Mentovai		10 years, 5 months
548002	Fix mingw compilation. (Closed)	cjacek	Ted Mielczarek		10 years, 5 months
530002	Stop using dynamic_cast in dwarf2reader (Closed)	Ted Mielczarek	jimb		10 years, 5 months
519002	Rework PostfixEvaluator to use a UniqueString type (Closed)	Ted Mielczarek	jimb		10 years, 5 months
520002	Replace map<UniqueString*> with UniqueStringMap (Closed)	Ted Mielczarek	jimb		10 years, 5 months
511003	Add APIs for querying Module data (Closed)	Ted Mielczarek	jimb, Mark Mentovai, Lei Zhang (chromium), glandium	2	10 years, 5 months
516004	Change representation of CFI rules (Closed)	Ted Mielczarek	Mark Mentovai, jimb		10 years, 5 months
1114003	Expose ExceptionHandler::HandleSignal for use in non-breakpad signal handlers. (Closed)	Jed Davis	Ted Mielczarek		10 years, 5 months
1724002	Linux multiprocess crash reporter: use pipe instead of socketpair in the client. (Closed)	Jed Davis	Ted Mielczarek		10 years, 5 months
7724002	Remove workaround for Linux credential-passing bug. (Closed)	Jed Davis	Ted Mielczarek		10 years, 5 months
5754002	Introduce microdump writer class. (Closed)	primiano	mmandlis, Mark Mentovai	42	10 years, 5 months
6764002	Update breakpad to support Android NDK r10c (Closed)	fdegans	primiano, Mark Mentovai, rmcilroy	2	10 years, 5 months
10694002	Remove unecessary headers following NDK r10c update. (Closed)	fdegans	rmcilroy, primiano		10 years, 5 months
6754003	Revert "Remove unecessary headers following NDK r10c update." (Closed)	primiano	rmcilroy, fdegans		10 years, 5 months
7734002	Refactor .so name detection logic in minidump/linux_dumper. (Closed)	primiano	Lei Zhang (chromium), mmandlis, Ted Mielczarek	12	10 years, 5 months
6754002	Fixing the Mac Inspector build (Closed)	ivanpe	Mark Mentovai, mmandlis		10 years, 5 months
1744002	The process uptime computation when the Windows out-of-process Crash Generation (Closed)	ivanpe	Mark Mentovai, mmandlis, Jess		10 years, 5 months
1114002	make "make install" also install headers and pkgconfig files (Closed)	jturney	vapier	7	10 years, 5 months

« Newest ‹ Newer 41 - 60 Older ›