Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 221 - 240 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
635002	In NonAllocatingMap, remove asserts around key/value length. (Closed)	rsesek	Mark Mentovai		12 years, 10 months
632003	Stricter validation checks for symbol parser functions. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess	10	12 years, 10 months
633002	Fix the Android/MIPS build. (Closed)	digit	Mark Mentovai, thakis, Ivan Penkov, Petar Jovanovic, gordana.cmiljanovic, Petar.Jovanovic		12 years, 10 months
632002	Adding mips support for Android. (Closed)	gordanac	Mark Mentovai, Ivan Penkov, digit	1	12 years, 10 months
629002	Handle block helper functions in Breakpad symbol parser. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess		12 years, 10 months
630002	Fix for a clang error which is introduced by change r1212. (Closed)	gordanac	Ivan Penkov, Mark Mentovai		12 years, 10 months
614002	[MIPS] Add support for Breakpad for MIPS (Closed)	gordanac	Ted Mielczarek, Ben Chan, Lei Zhang (chromium), digit, vapier, cjhopman, Ivan Penkov, Mark Mentovai, mankapura	88	12 years, 10 months
628002	Fixing minidump_dump to handle nacl dumps. (Closed)	bradnelson	Mark Mentovai, mseaborn		12 years, 10 months
626002	Fixing minidump_dump to handle nacl dumps. (Closed)	bradnelson	Mark Mentovai, mseaborn		12 years, 10 months
627002	Update to build against the latest revision of linux_syscall_support.h (Closed)	mseaborn	Mark Mentovai		12 years, 10 months
624002	Make StackWalkerAddressList use FRAME_TRUST_PREWALKED trust level. (Closed)	chrisha	Mark Mentovai		12 years, 10 months
621002	Create StackFrame::FRAME_TRUST_PREWALKED trust type. (Closed)	chrisha	Ted Mielczarek, Mark Mentovai	7	12 years, 10 months
620002	Create StackwalkerAddressList. (Closed)	chrisha	Mark Mentovai, ivanpe.google, Ivan Penkov, Ted Mielczarek	20	12 years, 11 months
526002	fix size types w/x32 (Closed)	vapier	Lei Zhang (chromium), Ted Mielczarek		12 years, 11 months
618002	Enable SIGABRT handler on desktop OS X (Closed)	Ted Mielczarek	Mark Mentovai	3	12 years, 11 months
400002	Mechanical change to allow the co-existance of std::string with a global ::string class (Closed)	ivanpe.google		34	12 years, 12 months
617002	Updating MDRawMiscInfo to support verions 3 and 4 of the MINIDUMP_MISC_INFO_N structure (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Siggi, Jess, mmandlis1	27	12 years, 12 months
616002	Fix erronoius address of crashinfo.auxv in minidump-2-core. (Closed)	Lei Zhang (chromium)	ajwong		13 years
550002	Make all linux ptrace dumper tests use a subprocess (Closed)	glandium	Ted Mielczarek	4	13 years
613002	Detect corrupt symbol files during minidump processing. Recover from the errors and use the good d… (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess, mmandlis1, Lei Zhang (chromium)	11	13 years

« Newest ‹ Newer 221 - 240 Older ›