Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(540)

Issue 626002: Fixing minidump_dump to handle nacl dumps. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by bradnelson
Modified:
10 years, 8 months ago
Reviewers:
Mark Mentovai, mseaborn
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/google-breakpad.git@master
Visibility:
Public.

Description

Fixing minidump_dump to handle nacl dumps.

Since nacl was not listed in decoding the code identifier, minidump_dump
produces errors like this (and non-zero return code):
2013-09-05 13:41:04: minidump.cc:2044: ERROR: MinidumpModule code_identifier
requires known platform, found 0x8205

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested with minidumps from nacl locally
R=mark@chromium.org,mseaborn@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/minidump.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
bradnelson
10 years, 8 months ago #1
mseaborn
It's not clear to me what you're fixing. What's the output of minidump_dump before and ...
10 years, 8 months ago #2
Mark Mentovai
LGTM. On non-Windows, there are no code identifiers, only debug identifiers.
10 years, 8 months ago #3
bradnelson
10 years, 8 months ago #4
Updated description
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted