Issue 550002: Make all linux ptrace dumper tests use a subprocess

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 550002: Make all linux ptrace dumper tests use a subprocess (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by glandium

Modified:
10 years, 9 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Make all linux ptrace dumper tests use a subprocess

Patch Set 2 : Whitespace fixes for pointers #

Patch Set 3 : More whitespace fixes for pointers #

Total comments: 4

Patch Set 4 : Updated #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1 2 3	10 chunks	+201 lines, -191 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Ted Mielczarek

A few things I'd like to see cleaned up. https://breakpad.appspot.com/550002/diff/7001/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc File src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc (right): https://breakpad.appspot.com/550002/diff/7001/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc#newcode76 src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc:76: ...

10 years, 11 months ago #4

Ted Mielczarek

10 years, 11 months ago #7

This actually needed a fix to pass all the tests on Ubuntu, in
LinuxPtraceDumperChildTest::SetUp:
prctl(PR_SET_PTRACER, child_pid_);

Expand All Messages | Collapse All Messages