Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 181 - 200 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
854002	Remove usage of gDebugLog by directly using the VERBOSE preprocessor define (Closed)	altse	Mark Mentovai		12 years, 3 months
824002	Avoid redefinition of global static debug flag and remove unneeded GTMDefines.h" (Closed)	altse	Mark Mentovai, mostynb, altse		12 years, 3 months
834002	Include guards and avoid redefinition of false/true in convert_UTF. (Closed)	altse	Mark Mentovai		12 years, 3 months
904002	Add -[BreakpadController resetConfiguration] for iOS. (Closed)	kiyun	blundell	4	12 years, 3 months
714002	Provide BreakpadGetCrashReportCount() and -[BreakpadController getCrashReportCount:] (Closed)	kiyun	Mark Mentovai, qsr		12 years, 3 months
884002	disable unittests under ASAN that use memory crashes (Closed)	vapier	Lei Zhang (chromium), Ted Mielczarek, Ben Chan		12 years, 3 months
834003	Address additional comments from r1248. Fix the register to check and fix some style nits. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek	2	12 years, 3 months
824003	Conditionalize use of <cpuid.h> header (Closed)	Roland McGrath	Mark Mentovai		12 years, 3 months
864003	Use AM_MAINTAINER_MODE so configure supports --enable-maintainer-mode (Closed)	Roland McGrath	bradnelson, Mark Mentovai, Ted Mielczarek, mcgrathr		12 years, 3 months
619002	check for and enable Large File Support automatically (Closed)	vapier	Lei Zhang (chromium), Ted Mielczarek, Ben Chan		12 years, 3 months
864002	Add MMX detection when getting registers in Linux. (Closed)	Lei Zhang (chromium)	Ted Mielczarek, aras.vaichas, Mark Mentovai	4	12 years, 3 months
874002	Fix Windows release build error due to unreferenced variables. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Erik Wright		12 years, 3 months
844002	switch armv7 setting to arm_version==7 in breakpad (Closed)	mostynb	Mark Mentovai		12 years, 3 months
641002	Do not read CFI section when not outputing CFI information. (Closed)	qsr	Ted Mielczarek, Mark Mentovai		12 years, 3 months
704002	Process minidumps generated on ARM64 in iOS apps. (Closed)	blundell	Mark Mentovai, Ted Mielczarek	48	12 years, 3 months
814002	Fix unused method warning. (Closed)	Ivan Penkov	Mark Mentovai, blundell, Jess		12 years, 3 months
794002	Fixing several instances of wrong printf format specifiers. (Closed)	Ivan Penkov	Mark Mentovai, blundell, Jess		12 years, 3 months
804002	Add missing #include of eintr_wrapper.h to auto_testfile.h (Closed)	Mark Mentovai	blundell		12 years, 3 months
784002	Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close (Closed)	Mark Mentovai	Ted Mielczarek		12 years, 3 months
774002	Re-enable ios_exception_minidump_generator being built on non-ARM. (Closed)	blundell	Mark Mentovai		12 years, 3 months

« Newest ‹ Newer 181 - 200 Older ›