Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 101 - 120 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
7654002	Print more x86-64 registers in minidump_stackwalk (Closed)	Ted Mielczarek	Mark Mentovai		11 years, 3 months
3684002	Linux: Fix a memory leak in ExceptionHandler. (Closed)	Lei Zhang (chromium)	Mark Mentovai		11 years, 3 months
2704002	Fix a memory leak in DwarfCUToModule::FuncHandler::Finish(). (Closed)	Lei Zhang (chromium)	Mark Mentovai		11 years, 3 months
3664002	[MIPS] Fix core dump related unit tests for Android on MIPS (Closed)	gordanac	Ivan Penkov, digit, Mark Mentovai, Ben Chan	6	11 years, 4 months
3674002	Fix minor typo in a comment in r1331. (Closed)	rmcilroy	qsr, qsr1		11 years, 4 months
2694002	Fix x86_64 Android build after user_fpregs_struct was added to /sys/user.h in newer NDKs (Closed)	rmcilroy	Mark Mentovai, qsr1	2	11 years, 4 months
2684002	[Mac] Remove unused host_info call and supporting calls (Closed)	Mark Mentovai	blundell, qsr	2	11 years, 4 months
6654002	Fix the documentation for MinidumpFileWriter::Open(). (Closed)	Lei Zhang (chromium)	Mark Mentovai		11 years, 4 months
5664002	Add required build options to correctly target XP (Closed)	Will Harris	chrisha		11 years, 4 months
1674002	FD leaks and handle errors better. (Closed)	rsesek			11 years, 4 months
1664002	Add support for CFI based stack walking on Arm64. (Closed)	rmcilroy	Mark Mentovai, blundell	4	11 years, 4 months
2664002	Make the Linux CrashGenerationClient an interface. (Closed)	rsesek	Mark Mentovai, mdempsky	23	11 years, 4 months
1654002	Add Arm64 support to dumpsyms. (Closed)	rmcilroy	Mark Mentovai, blundell		11 years, 4 months
2654002	Clean up common.gypi. (Closed)	chrisha	mmentovai, Mark Mentovai		11 years, 4 months
1644002	Linux: Check the CRC32 of the debug link file in the symbol dumper. (Closed)	Lei Zhang (chromium)	Mark Mentovai	5	11 years, 4 months
1634002	Change PrintFunctions to print functions in address order and not print duplicate public functions. (Closed)	Will Harris	Mark Mentovai	8	11 years, 4 months
1624003	Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped. (Closed)	rmcilroy	Lei Zhang (chromium)		11 years, 4 months
1584002	minidump-2-core: Allow user to override shared lib basedir. (Closed)	Lei Zhang (chromium)	kouhei		11 years, 5 months
1574002	Change the way function and public symbols are obtained to use the findChildren DIA function. (Closed)	Will Harris	Mark Mentovai, bsmedberg, ivanpe	15	11 years, 5 months
1554002	Allow symupload to upload to multiple URLs on the same commandline (Closed)	Will Harris	Mark Mentovai	1	11 years, 5 months

« Newest ‹ Newer 101 - 120 Older ›