Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 1644002: Linux: Check the CRC32 of the debug link file in the symbol dumper. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Lei Zhang (chromium)
Modified:
9 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Linux: Check the CRC32 of the debug link file in the symbol dumper.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1320

Patch Set 1 #

Patch Set 2 : do a better job of searching through multiple directories #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 3 chunks +3 lines, -0 lines 0 comments Download
M Makefile.in View 12 chunks +28 lines, -2 lines 0 comments Download
A src/common/linux/crc32.cc View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A src/common/linux/crc32.h View 1 chunk +53 lines, -0 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 10 chunks +52 lines, -23 lines 0 comments Download

Messages

Total messages: 4
Lei Zhang (chromium)
And almost 4 years later, I finally got around to fixing my TODO.
9 years, 11 months ago #1
Mark Mentovai
LGTM! https://breakpad.appspot.com/1644002/diff/30001/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode465 Makefile.am:465: src/common/linux/crc32.cc \ Sort: c < d https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode514 Makefile.am:514: ...
9 years, 11 months ago #2
Lei Zhang (chromium)
https://breakpad.appspot.com/1644002/diff/30001/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1644002/diff/30001/Makefile.am#newcode465 Makefile.am:465: src/common/linux/crc32.cc \ On 2014/04/23 13:31:50, Mark Mentovai wrote: > ...
9 years, 11 months ago #3
Lei Zhang (chromium)
9 years, 11 months ago #4
Message was sent while issue was closed.
Committed patchset #3 manually as r1320 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted