Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 81 - 100 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
6784002	MSVC 2013 build fix: error C2036: 'void *' : unknown size	zomps0			10 years, 6 months
6764002	Update breakpad to support Android NDK r10c (Closed)	fdegans	primiano, Mark Mentovai, rmcilroy	2	10 years, 6 months
10694002	Remove unecessary headers following NDK r10c update. (Closed)	fdegans	rmcilroy, primiano		10 years, 6 months
6754003	Revert "Remove unecessary headers following NDK r10c update." (Closed)	primiano	rmcilroy, fdegans		10 years, 6 months
7734002	Refactor .so name detection logic in minidump/linux_dumper. (Closed)	primiano	Lei Zhang (chromium), mmandlis, Ted Mielczarek	12	10 years, 6 months
6754002	Fixing the Mac Inspector build (Closed)	ivanpe	Mark Mentovai, mmandlis		10 years, 6 months
1744002	The process uptime computation when the Windows out-of-process Crash Generation (Closed)	ivanpe	Mark Mentovai, mmandlis, Jess		10 years, 6 months
1114002	make "make install" also install headers and pkgconfig files (Closed)	jturney	vapier	7	10 years, 6 months
4684002	Microdumps: refactor out common parts of minidump_writer.cc (Closed)	primiano	Mark Mentovai, mmandlis	6	10 years, 6 months
1734002	Fix some nits raised by Timur for r1385. (Closed)	Lei Zhang (chromium)	ivanpe		10 years, 6 months
6744002	IWYU in minidump_writer.cc to fix building with libc++ after r1385. (Closed)	Lei Zhang (chromium)	ivanpe		10 years, 6 months
5734002	Linux: Call memset() in a couple places in ExceptionHandler to avoid uninit memory reads under Valg… (Closed)	Lei Zhang (chromium)	ivanpe		10 years, 7 months
2804002	Linux ELF core tests: kernel.core_use_pid also affects core filename	Jed Davis			10 years, 7 months
4674002	dwarf: Minimal support for DWARF expressions	mdempsky	Lei Zhang (chromium), jimb	14	10 years, 7 months
5724002	Fix clang compilation error introduced in r1380. (Closed)	simonb	rmcilroy		10 years, 7 months
7714003	Extend mapping merge to include reserved but unused mappings. (Closed)	simonb	Lei Zhang (chromium), rmcilroy, Ted Mielczarek		10 years, 7 months
6734002	Add inttypes for windows in dump_context (Closed)	mmandlis	primiano		10 years, 7 months
7714002	GoogleCrashdumpUploader: adds Upload(string*) API to get the HTTP response. (Closed)	gunsch	Mark Mentovai, lcwu	7	10 years, 7 months
8674002	Fixes common_unittests build. (Closed)	Lei Zhang (chromium)	gunsch		10 years, 7 months
7704002	Fix Windows client unittests build: add missing code files (Closed)	mmandlis	Mark Mentovai, ivanpe		10 years, 7 months

« Newest ‹ Newer 81 - 100 Older ›