Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 121 - 140 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
10664002	Add frame pointer recovery to the AMD64 Stackwalker. (Closed)	rsesek	Mark Mentovai	7	12 years
7694002	Change some ELF utils to return the length as a size_t. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years
1134002	Ensure C:/Dumps/ exists in crash_generation_app (Closed)	j.turney	Ted Mielczarek		12 years
2724002	[NOT FOR REVIEW] Prototype to generate microdumps in logcat.	primiano			12 years
3704002	Stringify minidump stream_type constants in minidump_dump output (Closed)	Ted Mielczarek	Mark Mentovai	1	12 years
1684002	Allow build on VS2010 and VS2012	mkato	Ted Mielczarek	1	12 years
7674002	Fix compilation error in Linux libc++ builds due to use of tr1/.	earthdok	Mark Mentovai	4	12 years, 1 month
2714002	dump_syms: use unordered_set<> instead of set<> for speed.	uekawa	Mark Mentovai, earthdok	2	12 years, 1 month
6674002	Cleanup: hide undefined behavior from the compiler better. (Closed)	ivanpe	Ted Mielczarek, jcivelli, qsr, Mark Mentovai, digit		12 years, 1 month
9664002	Unhook current Breakpad object after handling uncaught NSException. (Closed)	pkl	qsr		12 years, 1 month
8664002	Make crash_handler volatile to prevent compiler optimizing it away. (Closed)	anton	Lei Zhang (chromium), rmcilroy		12 years, 1 month
10654002	Update output for test minidump_dump_test. (Closed)	ivanpe	Mark Mentovai		12 years, 1 month
5674002	minidump_dump: convert time_t values to UTC correctly. Interpret the (Closed)	Mark Mentovai	ivanpe	9	12 years, 1 month
600002	blocking on sys_wait	issac.xwork	Ted Mielczarek, Lei Zhang (chromium), thestig1, Mark Mentovai	4	12 years, 2 months
9654002	Use PAGE_MAX_SIZE. PAGE_SIZE is now a variable size. (Closed)	justincohen	qsr, Mark Mentovai		12 years, 2 months
7664002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos	ivanpe		12 years, 2 months
3694002	Add missing MD_MISCINFO_FLAGS1_BUILDSTRING (Closed)	Mark Mentovai	ivanpe	1	12 years, 2 months
8654002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos			12 years, 2 months
6664002	minidump_dump: Display x86 CPU vendor string for x86_64	Mark Mentovai	Ted Mielczarek		12 years, 2 months
7654002	Print more x86-64 registers in minidump_stackwalk (Closed)	Ted Mielczarek	Mark Mentovai		12 years, 2 months

« Newest ‹ Newer 121 - 140 Older ›