Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 361 - 380 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
476002	Update dump_syms to correctly filter on cpu subtype. (Closed)	qsr	Mark Mentovai	10	13 years, 2 months
478003	Fix minor Android build failure with Clang. (Closed)	digit	Mark Mentovai, Ted Mielczarek, qsr		13 years, 2 months
473002	Fix analyzer warning due to value assigned but not read. (Closed)	kenbongort	qsr		13 years, 2 months
475002	Add custom implementation of NXGetArchInfoXXX to allow adding new arch. (Closed)	qsr	Mark Mentovai, Ted Mielczarek	7	13 years, 2 months
460002	Fix linux compile errors for some systems. (Closed)	jakerr	Ted Mielczarek, qsr	5	13 years, 2 months
445002	Fix of a race condition during Crash Generation Server startup (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek		13 years, 2 months
470002	Fix the Linux build with clang. (Closed)	Lei Zhang (chromium)	cjhopman, Mark Mentovai		13 years, 2 months
471002	Merge trunk r1050 to chrome_23 branch. (Closed)	Lei Zhang (chromium)			13 years, 2 months
463004	Fix a bunch of small nits. (Closed)	Lei Zhang (chromium)	Mark Mentovai		13 years, 2 months
464002	Fix a parsing error in the Linux dump writer. (Closed)	Lei Zhang (chromium)	digit, Mark Mentovai		13 years, 2 months
457003	processor: add arm exception flags (Closed)	jaysoffian	qsr	4	13 years, 2 months
452002	Update GTM files to latest (Closed)	jakerr	qsr		13 years, 3 months
453002	Turn on more warnings in ios / mac projects. (Closed)	jakerr	qsr, Mark Mentovai	23	13 years, 3 months
449003	Support generating minidumps from live processes on Linux (Closed)	Ted Mielczarek	Mark Mentovai, Ben Chan, digit	19	13 years, 3 months
115002	Support generating minidumps from live processes on Windows (Closed)	Ted Mielczarek	Mark Mentovai, cjones	19	13 years, 3 months
450002	Allow registering memory regions to be included in dumps (Closed)	Ted Mielczarek	Mark Mentovai	13	13 years, 3 months
423002	Makefile update for gtest update vs. pthreads (Closed)	glandium	Ted Mielczarek		13 years, 3 months
456002	Make Windows ExceptionHandler::HandleException public (Closed)	Ted Mielczarek	Mark Mentovai		13 years, 3 months
446003	Fix compilation of linux crash_generation_server.cc, and add it to the client library sources so it… (Closed)	Ted Mielczarek	Mark Mentovai	1	13 years, 3 months
452003	Restore dump path setting functionality to Linux ExceptionHandler (Closed)	Ted Mielczarek	digit, jcivelli	1	13 years, 3 months

« Newest ‹ Newer 361 - 380 Older ›