Issue 452003: Restore dump path setting functionality to Linux ExceptionHandler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 452003: Restore dump path setting functionality to Linux ExceptionHandler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Ted Mielczarek

Modified:
11 years, 7 months ago

Reviewers:
digit, jcivelli

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

The changes in r1007 removed the dump_path/set_dump_path methods from
ExceptionHandler. Unfortunately we use those in Mozilla code. This patch adds an
ExceptionHandler::set_minidump_descriptor method, and also a
MinidumpDescriptor::directory method to restore this functionality. The const
changes on MinidumpDescriptor were not my favorite, but I don't see a better way
to make this work (and I have no idea why they were there in the first place).

Patch Set 2 : Updated per review #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/handler/exception_handler.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/exception_handler_unittest.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/minidump_descriptor.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/minidump_descriptor.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

digit

http://breakpad.appspot.com/452003/diff/1/src/client/linux/handler/minidump_descriptor.cc File src/client/linux/handler/minidump_descriptor.cc (right): http://breakpad.appspot.com/452003/diff/1/src/client/linux/handler/minidump_descriptor.cc#newcode55 src/client/linux/handler/minidump_descriptor.cc:55: c_path_ = NULL; Would it make sense to call ...

11 years, 7 months ago #2

lgtm

Expand All Messages | Collapse All Messages