Issue 423002: Makefile update for gtest update vs. pthreads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 423002: Makefile update for gtest update vs. pthreads (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by glandium

Modified:
11 years, 8 months ago

Reviewers:
Ted Mielczarek

Visibility:
Public.

More Reviews

Description

The external svn repo checked out under src/testing is old and makes unit tests
fail to build with gcc 4.7. Svn updating src/testing solves the problem at
compilation time, but unveils linkage problems (undefined symbols for various
pthread_* functions), which are solved with this patch.

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	Makefile.am	View		19 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

The gtest update was fixed in r1019: http://code.google.com/p/google-breakpad/source/detail?r=1019 Can you re-test with that?

11 years, 8 months ago #2

glandium

11 years, 8 months ago #3

On 2012/09/14 12:16:46, Ted Mielczarek wrote:
> The gtest update was fixed in r1019:
> http://code.google.com/p/google-breakpad/source/detail?r=1019
> 
> Can you re-test with that?

It was fixed in r1034:
https://breakpad.appspot.com/448002

Expand All Messages | Collapse All Messages